Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SDL message boxes #1249

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Simplify SDL message boxes #1249

merged 1 commit into from
Dec 20, 2022

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Dec 20, 2022 •
edited
Loading

It has what we want and needs less abstraction, overall simplifying the code

@Jan200101
Simplify SDL message boxes
3238677 
It has what we needs and needs less abstraction, overall simplifying the code
Guldoman
Guldoman approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use that on Windows too.

@jgmdev
Copy link
Member

jgmdev commented Dec 20, 2022

I wonder if we should use that on Windows too.

yeah, it is like if we are giving Windows a special treatment 😄

@jgmdev
Copy link
Member

jgmdev commented Dec 20, 2022

This is a no brainer so lets merge it!

@jgmdev jgmdev merged commit b584f1f into lite-xl:master Dec 20, 2022
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Jan 16, 2023
@Jan200101 @takase1121
Simplify SDL message boxes (lite-xl#1249)
69c2b5d 
It has what we needs and needs less abstraction, overall simplifying the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman approved these changes

@jgmdev jgmdev jgmdev approved these changes

Assignees
No one assigned
Labels
Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jan200101 @jgmdev @Guldoman