Fix some syntax errors #1243

takase1121 · 2022-12-18T12:45:04Z

Some fixes for uncommon code paths (when compiling for everything other than linux, windows, mac, etc.)

not sure if this change is appropriate, we need to make sure SIG_IGN is only set on POSIX targets. To verify this we might need to include unistd.h,

this is often overlooked when compiling for normal platforms

jgmdev · 2022-12-20T22:10:45Z

all officially supported targets are building well so lets merge this

* move signal.h inclusion outside of if-else block not sure if this change is appropriate, we need to make sure SIG_IGN is only set on POSIX targets. To verify this we might need to include unistd.h, * fix syntax error this is often overlooked when compiling for normal platforms

takase1121 added 2 commits December 18, 2022 20:38

move signal.h inclusion outside of if-else block

8e8cf6f

not sure if this change is appropriate, we need to make sure SIG_IGN is only set on POSIX targets. To verify this we might need to include unistd.h,

fix syntax error

142cef5

this is often overlooked when compiling for normal platforms

github-actions bot added the Category: C Core label Dec 18, 2022

takase1121 mentioned this pull request Dec 18, 2022

Reorganize resources/ + wasm target #1244

Merged

jgmdev merged commit 6d0e7f3 into lite-xl:master Dec 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some syntax errors #1243

Fix some syntax errors #1243

takase1121 commented Dec 18, 2022

jgmdev commented Dec 20, 2022

Fix some syntax errors #1243

Fix some syntax errors #1243

Conversation

takase1121 commented Dec 18, 2022

jgmdev commented Dec 20, 2022