Make divider in contextmenu less aggressive #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following changes are applied: - use divider color instead of caret; - add a vertical padding on the divider.
|
i dont mind the color of the divider (i actually like it) but the normal border color with the extra padding looks good too. 🤷♂️ |
|
I've just noticed that the |
|
for autocomplete it's better to leave as is |
jgmdev
approved these changes
Dec 20, 2022
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Jan 16, 2023
Following changes are applied: - use divider color instead of caret; - add a vertical padding on the divider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I propose the following change:
Obviously, the divider is even better if its color is brighter, or darker but it makes sense to me to use the same color as the context menu's border. It will feel less "cheap".
Here's a preview: