Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the currently selected item to CommandView validation #1203

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Pass the currently selected item to CommandView validation #1203

merged 1 commit into from
Nov 15, 2022

Conversation

Guldoman
Copy link
Member

This would allow checking that an item is indeed selected.

@jgmdev
Copy link
Member

jgmdev commented Nov 15, 2022

So no need to press tab when automatically selected?

@Guldoman
Copy link
Member Author

This is more for the cases where the actual item is needed to be checked instead of the inserted text.

For example in force_syntax (and this is the reason I actually created this PR) it currently crashes if the text input results in no items.
To check the validity of the input I'd have to do the fuzzy search again, while with this I'd only have to check if the selected item is valid.

@jgmdev jgmdev merged commit 519b91c into lite-xl:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Lua Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guldoman @jgmdev