MSVC Support #1199
Merged
MSVC Support #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jgmdev
reviewed
Nov 14, 2022
|
Please squash this. |
|
Always good to have additional tooling support, maybe this can in the future replace our msys builds since it can be 2x times faster on CI since less packages need to be retrieved, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation / Refactor of #915 due to lots of changes leading up to 2.1.
Lots of MultiByteToWideChar is already standardized in 2.1 so the patches does not apply to well. Besides that, I messed up the rebase so I'm going to abandon it and continue in this PR.
This PR does not aim to create a MSVC release, it aims to allow people to compile the code on MSVC and keep tabs on some MINGWism in the code.