Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: add raise_window() #1131

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

jgmdev
Copy link
Member

@jgmdev jgmdev commented Sep 29, 2022

I developed a 100% lua based IPC system and implemented optional single instance support so lite-xl doesn't opens a new instance for each newly opened file or directory, so we need a wrapper to SDL_RaiseWindow in order to give focus to the lite-xl window each time a user opens a file from another application as shown on the video:

ipc-window-focus.mp4

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a different name for the function, but this is fine too.

@jgmdev
Copy link
Member Author

jgmdev commented Sep 29, 2022

I'd prefer a different name for the function, but this is fine too.

Which name you suggest? I wasn't sure my self how to name it xD

@jgmdev jgmdev force-pushed the PR/add-window-focus branch 2 times, most recently from 82fdd99 to 6622a19 Compare September 29, 2022 15:16
@jgmdev
Copy link
Member Author

jgmdev commented Sep 29, 2022

renamed to raise_window() from window_focus() to be more in line with sdl2 as suggested by @Guldoman

@jgmdev jgmdev changed the title system: add window_focus() system: add raise_window() Sep 29, 2022
@jgmdev jgmdev force-pushed the PR/add-window-focus branch from 6622a19 to 66876a6 Compare September 29, 2022 15:25
@jgmdev jgmdev merged commit ba0a454 into lite-xl:master Sep 29, 2022
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants