Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin scale: added option to set default scale #1115

Merged
merged 1 commit into from
Sep 15, 2022
Merged

plugin scale: added option to set default scale #1115

merged 1 commit into from
Sep 15, 2022

Conversation

jgmdev
Copy link
Member

@jgmdev jgmdev commented Sep 13, 2022

As title says plus changed default mode to ui and added config spec option to allow settings gui modification:

default-scale-option

jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 13, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
460d069
@jgmdev jgmdev force-pushed the PR/scale-default-option branch from 4f35957 to 161e64b Compare September 13, 2022 21:17
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 13, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
62a841f
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 13, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
86b43d6
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 13, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
3c8f5ec
@jgmdev jgmdev force-pushed the PR/scale-default-option branch from 161e64b to 8a69ef6 Compare September 14, 2022 00:00
@Guldoman
Copy link
Member

changed default mode to ui

Mmm I don't think this is a good idea. Normally when zooming with the scroll wheel you expect it to make only the content bigger, not the whole UI.
We should probably add two different commands that do each thing separately.

@jgmdev jgmdev force-pushed the PR/scale-default-option branch from 8a69ef6 to afe643f Compare September 15, 2022 04:39
@jgmdev
Copy link
Member Author

jgmdev commented Sep 15, 2022

Mmm I don't think this is a good idea. Normally when zooming with the scroll wheel you expect it to make only the content bigger, not the whole UI. We should probably add two different commands that do each thing separately.

In my opinion makes more sense to scale everything together to keep the whole interface uniform since this isn't a web browser, even visual studio code scales everything together except for the menu bar. Anyways, I reverted the default scaling mode back to code since I can still choose what I consider the sane option locally :), will merge this small change for now.

@jgmdev jgmdev merged commit 862ed9a into lite-xl:master Sep 15, 2022
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 16, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
5aedb3a
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 16, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
cf5aa63
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 22, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
d5e86e3
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 22, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
29c4823
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 22, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
d802095
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 22, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
c38116f
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 23, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
2d907b8
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Sep 23, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
92e2768
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 2, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
2883c47
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 2, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
b3ba18c
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 3, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
a48674f
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 3, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
5848c69
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 5, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
b0a530c
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 9, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
794b53b
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 9, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
5f7963f
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 11, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
19f8e57
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 11, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
deda2c3
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Oct 13, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
87678dd
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Nov 30, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
695b64e
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Nov 30, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
3459ee9
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 1, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
a68d7a9
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 2, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
8647a21
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 2, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
c4cddd7
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
fd2b34f
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
f67e9b1
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
d6f4b5b
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
34bc9a2
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
889e9b5
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 14, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
c40ac9d
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 21, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
da97a4e
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 21, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
d7969e8
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 21, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
2aa6e35
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 21, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
e359af2
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 26, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
2100ae3
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 26, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
ebf54bc
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 28, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
6b7cb0c
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 28, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
f6a8930
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 28, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
5044144
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 29, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
18cbba1
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Dec 29, 2022
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
32c19b7
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 6, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
3676783
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 6, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
af9df97
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 6, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
cd6de78
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 8, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
5b27776
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 8, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
f4a5ed9
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 8, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
166b009
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 15, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
9a32bcb
jgmdev added a commit to jgmdev/lite-xl that referenced this pull request Jan 15, 2023
@jgmdev
removed scale suggestion code since lite-xl#1115 is a better approach
094e4de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgmdev @Guldoman