Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak and wrong check in font_retrieve #1039

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix memory leak and wrong check in font_retrieve #1039

merged 1 commit into from
Jun 15, 2022

Conversation

takase1121
Copy link
Member

This is a pretty high priority fix for a memory leak in font_retrieve (caught by ASAN).

@jgmdev
Copy link
Member

jgmdev commented Jun 15, 2022

Confirming that this also fixes the issue of stack smash when adding more than 3 fonts to a group.

@jgmdev
Copy link
Member

jgmdev commented Jun 15, 2022

Merging this since we should not delay it

@jgmdev jgmdev merged commit 0c7a132 into lite-xl:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman left review comments

Assignees
No one assigned
Labels
Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takase1121 @jgmdev @Guldoman