Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suggestion wrapping for CommandView #1003

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

zesterer
Copy link
Contributor

No description provided.

@jgmdev
Copy link
Member

jgmdev commented May 30, 2022

Works properly, some contributors are worried about the increase on parameters count for the CommandVIew:enter function, but that can be revised on the future to allow an options table if the amount of options keep increasing. This PR doesn't breaks compatibility and introduces a useful feature so merging.

@jgmdev jgmdev merged commit f1f61f0 into lite-xl:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants