Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/signals] Update dependencies - use wide range for lit #4791

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[labs/signals] Update dependencies - use wide range for lit #4791

merged 1 commit into from
Oct 7, 2024

Conversation

justinfagnani
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: efbe8eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +7% (-1.21ms - +0.95ms)
    this-change vs tip-of-tree

render

  • this-change: 45.85ms - 56.91ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +5% (-0.22ms - +0.89ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.56ms - +0.33ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -35% - +3% (-28.56ms - +3.69ms)
    this-change vs tip-of-tree

update

  • this-change: 492.19ms - 496.16ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +4% (-1.42ms - +1.60ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.56ms - +1.63ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-0.01ms - +11.45ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 490.36ms - 497.38ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-5.79ms - +2.24ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.85ms - 56.91ms-

update

VersionAvg timevs
492.19ms - 496.16ms-

update-reflect

VersionAvg timevs
490.36ms - 497.38ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.08ms - 20.00ms-unsure 🔍
-1% - +5%
-0.22ms - +0.89ms		unsure 🔍
-0% - +6%
-0.04ms - +1.13ms
tip-of-tree
tip-of-tree		18.90ms - 19.51msunsure 🔍
-5% - +1%
-0.89ms - +0.22ms		-unsure 🔍
-1% - +4%
-0.26ms - +0.68ms
previous-release
previous-release		18.64ms - 19.36msunsure 🔍
-6% - +0%
-1.13ms - +0.04ms		unsure 🔍
-4% - +1%
-0.68ms - +0.26ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.29ms - 39.61ms-unsure 🔍
-4% - +4%
-1.42ms - +1.60ms		unsure 🔍
-3% - +4%
-1.25ms - +1.63ms
tip-of-tree
tip-of-tree		37.40ms - 39.32msunsure 🔍
-4% - +4%
-1.60ms - +1.42ms		-unsure 🔍
-3% - +4%
-1.19ms - +1.39ms
previous-release
previous-release		37.40ms - 39.12msunsure 🔍
-4% - +3%
-1.63ms - +1.25ms		unsure 🔍
-4% - +3%
-1.39ms - +1.19ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.88ms - 13.39ms-unsure 🔍
-9% - +7%
-1.21ms - +0.95ms		unsure 🔍
-7% - +9%
-0.89ms - +1.17ms
tip-of-tree
tip-of-tree		11.99ms - 13.53msunsure 🔍
-8% - +10%
-0.95ms - +1.21ms		-unsure 🔍
-6% - +11%
-0.77ms - +1.31ms
previous-release
previous-release		11.79ms - 13.19msunsure 🔍
-9% - +7%
-1.17ms - +0.89ms		unsure 🔍
-10% - +6%
-1.31ms - +0.77ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.27ms - 34.96ms-unsure 🔍
-2% - +1%
-0.56ms - +0.33ms		unsure 🔍
-2% - +1%
-0.80ms - +0.32ms
tip-of-tree
tip-of-tree		34.46ms - 35.02msunsure 🔍
-1% - +2%
-0.33ms - +0.56ms		-unsure 🔍
-2% - +1%
-0.65ms - +0.40ms
previous-release
previous-release		34.42ms - 35.30msunsure 🔍
-1% - +2%
-0.32ms - +0.80ms		unsure 🔍
-1% - +2%
-0.40ms - +0.65ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.11ms - 69.83ms-unsure 🔍
-1% - +2%
-0.56ms - +1.63ms		unsure 🔍
-1% - +2%
-0.77ms - +1.46ms
tip-of-tree
tip-of-tree		67.76ms - 69.12msunsure 🔍
-2% - +1%
-1.63ms - +0.56ms		-unsure 🔍
-2% - +1%
-1.17ms - +0.79ms
previous-release
previous-release		67.92ms - 69.34msunsure 🔍
-2% - +1%
-1.46ms - +0.77ms		unsure 🔍
-1% - +2%
-0.79ms - +1.17ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
53.84ms - 76.33ms-unsure 🔍
-35% - +3%
-28.56ms - +3.69ms		unsure 🔍
-12% - +48%
-5.53ms - +25.05ms
tip-of-tree
tip-of-tree		65.96ms - 89.07msunsure 🔍
-8% - +46%
-3.69ms - +28.56ms		-slower ❌
7% - 74%
6.67ms - 37.71ms
previous-release
previous-release		44.96ms - 65.69msunsure 🔍
-37% - +7%
-25.05ms - +5.53ms		faster ✔
12% - 46%
6.67ms - 37.71ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
501.23ms - 510.34ms-unsure 🔍
-0% - +2%
-0.01ms - +11.45ms		unsure 🔍
-2% - +1%
-11.52ms - +3.61ms
tip-of-tree
tip-of-tree		496.59ms - 503.54msunsure 🔍
-2% - -0%
-11.45ms - +0.01ms		-faster ✔
1% - 3%
2.71ms - 16.65ms
previous-release
previous-release		503.70ms - 515.79msunsure 🔍
-1% - +2%
-3.61ms - +11.52ms		slower ❌
1% - 3%
2.71ms - 16.65ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
532.71ms - 539.59ms-unsure 🔍
-1% - +0%
-5.79ms - +2.24ms		unsure 🔍
-2% - +2%
-10.09ms - +8.18ms
tip-of-tree
tip-of-tree		535.86ms - 540.00msunsure 🔍
-0% - +1%
-2.24ms - +5.79ms		-unsure 🔍
-1% - +2%
-7.89ms - +9.53ms
previous-release
previous-release		528.64ms - 545.57msunsure 🔍
-2% - +2%
-8.18ms - +10.09ms		unsure 🔍
-2% - +1%
-9.53ms - +7.89ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani enabled auto-merge (squash) October 7, 2024 19:34
@justinfagnani justinfagnani merged commit 9566ad5 into main Oct 7, 2024
9 checks passed
@justinfagnani justinfagnani deleted the signals-deps branch October 7, 2024 19:48
@lit-robot lit-robot mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustjk augustjk augustjk approved these changes

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@graynorton graynorton Awaiting requested review from graynorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinfagnani @rictic @augustjk