Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump typescript #4520

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Bump typescript #4520

merged 4 commits into from
Jan 31, 2024

Conversation

justinfagnani
Copy link
Collaborator

Breaking out part of #4516 to isolate test flakiness

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b6eb8f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@lit/ts-transformers Patch
@lit-labs/analyzer Patch
@lit-labs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justinfagnani justinfagnani requested review from augustjk and removed request for kevinpschaaf January 25, 2024 02:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +5% (-0.47ms - +0.55ms)
    this-change vs tip-of-tree

render

  • this-change: 47.44ms - 49.22ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +0% (-1.19ms - +0.08ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +2% (-1.56ms - +0.74ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +4% (-0.03ms - +1.23ms)
    this-change vs tip-of-tree

update

  • this-change: 488.40ms - 492.07ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +3% (-3.40ms - +1.40ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-2.47ms - +1.90ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-1.47ms - +2.88ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 492.71ms - 497.19ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-0.99ms - +3.12ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
47.44ms - 49.22ms-

update

VersionAvg timevs
488.40ms - 492.07ms-

update-reflect

VersionAvg timevs
492.71ms - 497.19ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.28ms - 19.10ms-unsure 🔍
-6% - +0%
-1.19ms - +0.08ms		unsure 🔍
-5% - +1%
-0.98ms - +0.27ms
tip-of-tree
tip-of-tree		18.77ms - 19.72msunsure 🔍
-0% - +6%
-0.08ms - +1.19ms		-unsure 🔍
-2% - +5%
-0.47ms - +0.87ms
previous-release
previous-release		18.58ms - 19.51msunsure 🔍
-1% - +5%
-0.27ms - +0.98ms		unsure 🔍
-4% - +2%
-0.87ms - +0.47ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.33ms - 41.60ms-unsure 🔍
-8% - +3%
-3.40ms - +1.40ms		unsure 🔍
-5% - +7%
-2.11ms - +2.78ms
tip-of-tree
tip-of-tree		39.21ms - 42.73msunsure 🔍
-4% - +9%
-1.40ms - +3.40ms		-unsure 🔍
-3% - +10%
-1.20ms - +3.87ms
previous-release
previous-release		37.81ms - 41.45msunsure 🔍
-7% - +5%
-2.78ms - +2.11ms		unsure 🔍
-9% - +3%
-3.87ms - +1.20ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.99ms - 11.64ms-unsure 🔍
-4% - +5%
-0.47ms - +0.55ms		unsure 🔍
-2% - +7%
-0.20ms - +0.81ms
tip-of-tree
tip-of-tree		10.88ms - 11.66msunsure 🔍
-5% - +4%
-0.55ms - +0.47ms		-unsure 🔍
-3% - +7%
-0.29ms - +0.81ms
previous-release
previous-release		10.62ms - 11.40msunsure 🔍
-7% - +2%
-0.81ms - +0.20ms		unsure 🔍
-7% - +2%
-0.81ms - +0.29ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.88ms - 35.53ms-unsure 🔍
-4% - +2%
-1.56ms - +0.74ms		unsure 🔍
-3% - +4%
-1.03ms - +1.25ms
tip-of-tree
tip-of-tree		34.32ms - 35.91msunsure 🔍
-2% - +5%
-0.74ms - +1.56ms		-unsure 🔍
-2% - +5%
-0.60ms - +1.64ms
previous-release
previous-release		33.81ms - 35.39msunsure 🔍
-4% - +3%
-1.25ms - +1.03ms		unsure 🔍
-5% - +2%
-1.64ms - +0.60ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.75ms - 71.67ms-unsure 🔍
-4% - +3%
-2.47ms - +1.90ms		unsure 🔍
-3% - +3%
-2.35ms - +2.24ms
tip-of-tree
tip-of-tree		68.87ms - 72.12msunsure 🔍
-3% - +4%
-1.90ms - +2.47ms		-unsure 🔍
-3% - +4%
-2.17ms - +2.63ms
previous-release
previous-release		68.50ms - 72.03msunsure 🔍
-3% - +3%
-2.24ms - +2.35ms		unsure 🔍
-4% - +3%
-2.63ms - +2.17ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.89ms - 34.82ms-unsure 🔍
-0% - +4%
-0.03ms - +1.23ms		unsure 🔍
-1% - +3%
-0.34ms - +0.94ms
tip-of-tree
tip-of-tree		33.34ms - 34.18msunsure 🔍
-4% - +0%
-1.23ms - +0.03ms		-unsure 🔍
-3% - +1%
-0.91ms - +0.31ms
previous-release
previous-release		33.62ms - 34.50msunsure 🔍
-3% - +1%
-0.94ms - +0.34ms		unsure 🔍
-1% - +3%
-0.31ms - +0.91ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
498.84ms - 501.92ms-unsure 🔍
-0% - +1%
-1.47ms - +2.88ms		unsure 🔍
-1% - +0%
-2.61ms - +1.67ms
tip-of-tree
tip-of-tree		498.14ms - 501.21msunsure 🔍
-1% - +0%
-2.88ms - +1.47ms		-unsure 🔍
-1% - +0%
-3.31ms - +0.96ms
previous-release
previous-release		499.37ms - 502.33msunsure 🔍
-0% - +1%
-1.67ms - +2.61ms		unsure 🔍
-0% - +1%
-0.96ms - +3.31ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
503.96ms - 506.84ms-unsure 🔍
-0% - +1%
-0.99ms - +3.12ms		unsure 🔍
-1% - +0%
-2.57ms - +1.74ms
tip-of-tree
tip-of-tree		502.87ms - 505.81msunsure 🔍
-1% - +0%
-3.12ms - +0.99ms		-unsure 🔍
-1% - +0%
-3.65ms - +0.69ms
previous-release
previous-release		504.22ms - 507.42msunsure 🔍
-0% - +1%
-1.74ms - +2.57ms		unsure 🔍
-0% - +1%
-0.69ms - +3.65ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

The size of lit-html.js and lit-core.min.js are as expected.

@augustjk
Copy link
Member

Build is failing due to some @web/dev-server plugin types. Perhaps TS update is not possible without updating @web/ stuff too.

@justinfagnani
Copy link
Collaborator Author

I do not understand why this built locally for me. Only failing on CI makes fixing it quite annoying :/

@augustjk augustjk mentioned this pull request Jan 31, 2024
Closed
@justinfagnani justinfagnani merged commit 89c5bdf into main Jan 31, 2024
9 checks passed
@justinfagnani justinfagnani deleted the update-typescript branch January 31, 2024 00:35
@lit-robot lit-robot mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustjk augustjk augustjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinfagnani @augustjk