Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing deps #3643

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Update testing deps #3643

merged 2 commits into from
Feb 5, 2023

Conversation

justinfagnani
Copy link
Collaborator

One of the changes to @web/test-runner claims it fixes a crash during watch mode that I've seen a lot.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 948e7a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -10% - +9% (-2.31ms - +2.08ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 75.35ms - 81.54ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +4% (-2.01ms - +1.48ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -7% - +4% (-0.86ms - +0.43ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.09ms - +1.59ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +4% (-0.06ms - +2.06ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 750.96ms - 766.68ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +6% (-1.53ms - +4.94ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -0% - +4% (-1.36ms - +12.20ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.29ms - +1.57ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-7.96ms - +10.56ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 751.90ms - 760.60ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-6.80ms - +11.20ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
75.76ms - 80.79ms-

update

VersionAvg timevs
690.53ms - 702.22ms-

update-reflect

VersionAvg timevs
691.41ms - 699.35ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
29.32ms - 31.78ms-unsure 🔍
-6% - +4%
-1.85ms - +1.38ms		unsure 🔍
-8% - +2%
-2.65ms - +0.53ms
tip-of-tree
tip-of-tree		29.74ms - 31.83msunsure 🔍
-5% - +6%
-1.38ms - +1.85ms		-unsure 🔍
-7% - +2%
-2.28ms - +0.63ms
previous-release
previous-release		30.60ms - 32.62msunsure 🔍
-2% - +9%
-0.53ms - +2.65ms		unsure 🔍
-2% - +7%
-0.63ms - +2.28ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
78.07ms - 83.82ms-unsure 🔍
-2% - +8%
-1.19ms - +6.55ms		unsure 🔍
-3% - +9%
-2.15ms - +6.73ms
tip-of-tree
tip-of-tree		75.68ms - 80.86msunsure 🔍
-8% - +1%
-6.55ms - +1.19ms		-unsure 🔍
-6% - +5%
-4.65ms - +3.87ms
previous-release
previous-release		75.27ms - 82.04msunsure 🔍
-8% - +3%
-6.73ms - +2.15ms		unsure 🔍
-5% - +6%
-3.87ms - +4.65ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
22.18ms - 25.60ms-unsure 🔍
-13% - +4%
-3.34ms - +1.06ms		unsure 🔍
-16% - +3%
-4.05ms - +0.72ms
tip-of-tree
tip-of-tree		23.65ms - 26.41msunsure 🔍
-5% - +14%
-1.06ms - +3.34ms		-unsure 🔍
-10% - +6%
-2.69ms - +1.64ms
previous-release
previous-release		23.89ms - 27.22msunsure 🔍
-3% - +17%
-0.72ms - +4.05ms		unsure 🔍
-7% - +11%
-1.64ms - +2.69ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.54ms - 12.27ms-unsure 🔍
-4% - +6%
-0.43ms - +0.65ms		unsure 🔍
-5% - +3%
-0.65ms - +0.40ms
tip-of-tree
tip-of-tree		11.39ms - 12.19msunsure 🔍
-5% - +4%
-0.65ms - +0.43ms		-unsure 🔍
-6% - +3%
-0.79ms - +0.31ms
previous-release
previous-release		11.65ms - 12.41msunsure 🔍
-3% - +5%
-0.40ms - +0.65ms		unsure 🔍
-3% - +7%
-0.31ms - +0.79ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
266.31ms - 276.84ms-unsure 🔍
-4% - +2%
-10.54ms - +5.62ms		unsure 🔍
-2% - +3%
-5.90ms - +8.22ms
tip-of-tree
tip-of-tree		267.91ms - 280.17msunsure 🔍
-2% - +4%
-5.62ms - +10.54ms		-unsure 🔍
-2% - +4%
-4.10ms - +11.35ms
previous-release
previous-release		265.71ms - 275.11msunsure 🔍
-3% - +2%
-8.22ms - +5.90ms		unsure 🔍
-4% - +1%
-11.35ms - +4.10ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.29ms - 52.95ms-unsure 🔍
-3% - +1%
-1.85ms - +0.58ms		unsure 🔍
-2% - +2%
-1.14ms - +1.04ms
tip-of-tree
tip-of-tree		51.87ms - 53.64msunsure 🔍
-1% - +4%
-0.58ms - +1.85ms		-unsure 🔍
-1% - +3%
-0.55ms - +1.71ms
previous-release
previous-release		51.46ms - 52.88msunsure 🔍
-2% - +2%
-1.04ms - +1.14ms		unsure 🔍
-3% - +1%
-1.71ms - +0.55ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
107.27ms - 108.77ms-unsure 🔍
-1% - +1%
-0.94ms - +1.32ms		unsure 🔍
-2% - +1%
-1.86ms - +1.09ms
tip-of-tree
tip-of-tree		106.99ms - 108.68msunsure 🔍
-1% - +1%
-1.32ms - +0.94ms		-unsure 🔍
-2% - +1%
-2.10ms - +0.96ms
previous-release
previous-release		107.13ms - 109.68msunsure 🔍
-1% - +2%
-1.09ms - +1.86ms		unsure 🔍
-1% - +2%
-0.96ms - +2.10ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.49ms - 52.14ms-unsure 🔍
-0% - +4%
-0.06ms - +2.06ms		unsure 🔍
-1% - +3%
-0.74ms - +1.51ms
tip-of-tree
tip-of-tree		49.65ms - 50.98msunsure 🔍
-4% - +0%
-2.06ms - +0.06ms		-unsure 🔍
-3% - +1%
-1.62ms - +0.39ms
previous-release
previous-release		50.18ms - 51.69msunsure 🔍
-3% - +1%
-1.51ms - +0.74ms		unsure 🔍
-1% - +3%
-0.39ms - +1.62ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
774.07ms - 787.69ms-unsure 🔍
-1% - +1%
-7.96ms - +10.56ms		unsure 🔍
-1% - +1%
-9.30ms - +9.27ms
tip-of-tree
tip-of-tree		773.31ms - 785.85msunsure 🔍
-1% - +1%
-10.56ms - +7.96ms		-unsure 🔍
-1% - +1%
-10.21ms - +7.59ms
previous-release
previous-release		774.58ms - 787.20msunsure 🔍
-1% - +1%
-9.27ms - +9.30ms		unsure 🔍
-1% - +1%
-7.59ms - +10.21ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
793.62ms - 807.29ms-unsure 🔍
-1% - +1%
-6.80ms - +11.20ms		unsure 🔍
-1% - +1%
-7.82ms - +11.60ms
tip-of-tree
tip-of-tree		792.40ms - 804.12msunsure 🔍
-1% - +1%
-11.20ms - +6.80ms		-unsure 🔍
-1% - +1%
-9.36ms - +8.75ms
previous-release
previous-release		791.66ms - 805.47msunsure 🔍
-1% - +1%
-11.60ms - +7.82ms		unsure 🔍
-1% - +1%
-8.75ms - +9.36ms		-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani merged commit ecd8737 into main Feb 5, 2023
@justinfagnani justinfagnani deleted the update-test-deps branch February 5, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustjk augustjk augustjk approved these changes

@aomarks aomarks Awaiting requested review from aomarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinfagnani @augustjk