[infra] Upgrade package locks, and pin some broken deps #3092

aomarks · 2022-06-25T23:42:21Z

This upgrades all package locks. npm run upgrade should be stable as of this PR.

There were a few issues resulting from new dependencies that needed these fixes:

Pinned TypeScript versions in a couple of packages. We should be using ~ in general for TypeScript anyway, because TypeScript doesn't follow semver.
Pinned ts-clone-node version because of an unknown breaking change.
Changed import style for rollup-plugin-summary due to a presumed change in its export style.
Pinned @web/dev-server and other @web/test-* libraries in the tests package, because something has broken in a recent version. Filed [infra] Something broken for testing in recent @web/dev-server #3091 to track.

… change

changeset-bot · 2022-06-25T23:42:25Z

🦋 Changeset detected

Latest commit: 2364ab9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-06-25T23:42:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-0.48ms - +0.99ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +8% (-1.60ms - +6.10ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -1% - +4% (-0.25ms - +1.20ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +2% (-0.43ms - +0.24ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.70ms - +0.88ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -15% - +11% (-12.85ms - +9.05ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -5% - +4% (-42.95ms - +32.24ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-2.80ms - +2.38ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +5% (-12.68ms - +18.59ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +3% (-3.41ms - +3.91ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -9% - +10% (-86.00ms - +88.10ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +1% (-18.88ms - +6.33ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +3% (-24.91ms - +23.77ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3461
Commit: bf4267a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	74.19ms - 81.62ms	-	unsure 🔍 -2% - +8% -1.60ms - +6.10ms	faster ✔ 14% - 22% 12.93ms - 20.72ms
tip-of-tree tip-of-tree	74.65ms - 76.65ms	unsure 🔍 -8% - +2% -6.10ms - +1.60ms	-	faster ✔ 19% - 22% 17.55ms - 20.60ms
previous-release previous-release	93.58ms - 95.88ms	slower ❌ 16% - 28% 12.93ms - 20.72ms	slower ❌ 23% - 27% 17.55ms - 20.60ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.10ms - 862.19ms	-	unsure 🔍 -5% - +4% -42.95ms - +32.24ms	faster ✔ 32% - 37% 412.10ms - 475.27ms
tip-of-tree tip-of-tree	814.39ms - 868.61ms	unsure 🔍 -4% - +5% -32.24ms - +42.95ms	-	faster ✔ 32% - 37% 405.86ms - 470.80ms
previous-release previous-release	1261.96ms - 1297.70ms	slower ❌ 48% - 58% 412.10ms - 475.27ms	slower ❌ 47% - 57% 405.86ms - 470.80ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	809.52ms - 825.65ms	-	unsure 🔍 -2% - +1% -18.88ms - +6.33ms	faster ✔ 6% - 9% 55.67ms - 79.68ms
tip-of-tree tip-of-tree	814.17ms - 833.54ms	unsure 🔍 -1% - +2% -6.33ms - +18.88ms	-	faster ✔ 5% - 8% 48.25ms - 74.55ms
previous-release previous-release	876.36ms - 894.15ms	slower ❌ 7% - 10% 55.67ms - 79.68ms	slower ❌ 6% - 9% 48.25ms - 74.55ms	-

lit-html-kitchen-sink

Browser: chrome-headless 102.0.5005.115
Sample size: 30
Built by: Benchmarks #3461
Commit: bf4267a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.75ms - 30.86ms	-	unsure 🔍 -1% - +4% -0.25ms - +1.20ms	faster ✔ 10% - 14% 3.59ms - 4.93ms
tip-of-tree tip-of-tree	29.37ms - 30.29ms	unsure 🔍 -4% - +1% -1.20ms - +0.25ms	-	faster ✔ 12% - 15% 4.14ms - 5.32ms
previous-release previous-release	34.19ms - 34.93ms	slower ❌ 12% - 16% 3.59ms - 4.93ms	slower ❌ 14% - 18% 4.14ms - 5.32ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	79.35ms - 83.84ms	-	unsure 🔍 -3% - +3% -2.80ms - +2.38ms	faster ✔ 0% - 8% 0.05ms - 6.47ms
tip-of-tree tip-of-tree	80.51ms - 83.10ms	unsure 🔍 -3% - +3% -2.38ms - +2.80ms	-	faster ✔ 1% - 7% 0.42ms - 5.69ms
previous-release previous-release	82.56ms - 87.15ms	unsure 🔍 -0% - +8% +0.05ms - +6.47ms	slower ❌ 0% - 7% 0.42ms - 5.69ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.38ms - 26.52ms	-	unsure 🔍 -2% - +4% -0.48ms - +0.99ms	faster ✔ 10% - 15% 2.95ms - 4.35ms
tip-of-tree tip-of-tree	25.24ms - 26.16ms	unsure 🔍 -4% - +2% -0.99ms - +0.48ms	-	faster ✔ 11% - 15% 3.28ms - 4.52ms
previous-release previous-release	29.19ms - 30.01ms	slower ❌ 11% - 17% 2.95ms - 4.35ms	slower ❌ 13% - 18% 3.28ms - 4.52ms	-

lit-html-repeat

Browser: chrome-headless 102.0.5005.115
Sample size: 30
Built by: Benchmarks #3461
Commit: bf4267a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.48ms - 11.02ms	-	unsure 🔍 -4% - +2% -0.43ms - +0.24ms	faster ✔ 9% - 14% 1.08ms - 1.73ms
tip-of-tree tip-of-tree	10.65ms - 11.05ms	unsure 🔍 -2% - +4% -0.24ms - +0.43ms	-	faster ✔ 9% - 13% 1.04ms - 1.58ms
previous-release previous-release	11.98ms - 12.34ms	slower ❌ 10% - 16% 1.08ms - 1.73ms	slower ❌ 9% - 15% 1.04ms - 1.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	381.68ms - 406.61ms	-	unsure 🔍 -3% - +5% -12.68ms - +18.59ms	faster ✔ 21% - 28% 105.98ms - 147.58ms
tip-of-tree tip-of-tree	381.75ms - 400.63ms	unsure 🔍 -5% - +3% -18.59ms - +12.68ms	-	faster ✔ 22% - 28% 110.60ms - 148.88ms
previous-release previous-release	504.28ms - 537.58ms	slower ❌ 26% - 38% 105.98ms - 147.58ms	slower ❌ 28% - 38% 110.60ms - 148.88ms	-

lit-html-template-heavy

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3461
Commit: bf4267a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.23ms - 55.04ms	-	unsure 🔍 -3% - +2% -1.70ms - +0.88ms	faster ✔ 15% - 19% 9.44ms - 12.18ms
tip-of-tree tip-of-tree	53.63ms - 55.46ms	unsure 🔍 -2% - +3% -0.88ms - +1.70ms	-	faster ✔ 14% - 18% 9.02ms - 11.78ms
previous-release previous-release	63.91ms - 65.97ms	slower ❌ 17% - 23% 9.44ms - 12.18ms	slower ❌ 16% - 22% 9.02ms - 11.78ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	120.85ms - 125.48ms	-	unsure 🔍 -3% - +3% -3.41ms - +3.91ms	faster ✔ 12% - 16% 16.74ms - 23.29ms
tip-of-tree tip-of-tree	120.08ms - 125.75ms	unsure 🔍 -3% - +3% -3.91ms - +3.41ms	-	faster ✔ 12% - 17% 16.61ms - 23.93ms
previous-release previous-release	140.87ms - 145.50ms	slower ❌ 13% - 19% 16.74ms - 23.29ms	slower ❌ 13% - 20% 16.61ms - 23.93ms	-

reactive-element-list

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3461
Commit: bf4267a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	72.66ms - 88.41ms	-	unsure 🔍 -15% - +11% -12.85ms - +9.05ms	unsure 🔍 -23% - -0% -21.23ms - +0.09ms
tip-of-tree tip-of-tree	74.82ms - 90.04ms	unsure 🔍 -11% - +16% -9.05ms - +12.85ms	-	unsure 🔍 -21% - +1% -19.14ms - +1.79ms
previous-release previous-release	83.92ms - 98.29ms	unsure 🔍 -1% - +27% -0.09ms - +21.23ms	unsure 🔍 -3% - +24% -1.79ms - +19.14ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	856.93ms - 985.47ms	-	unsure 🔍 -9% - +10% -86.00ms - +88.10ms	unsure 🔍 -12% - +7% -112.95ms - +70.63ms
tip-of-tree tip-of-tree	861.44ms - 978.85ms	unsure 🔍 -10% - +9% -88.10ms - +86.00ms	-	unsure 🔍 -12% - +7% -110.19ms - +65.76ms
previous-release previous-release	876.83ms - 1007.89ms	unsure 🔍 -8% - +12% -70.63ms - +112.95ms	unsure 🔍 -7% - +12% -65.76ms - +110.19ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	882.43ms - 919.90ms	-	unsure 🔍 -3% - +3% -24.91ms - +23.77ms	unsure 🔍 -2% - +4% -18.29ms - +31.76ms
tip-of-tree tip-of-tree	886.21ms - 917.26ms	unsure 🔍 -3% - +3% -23.77ms - +24.91ms	-	unsure 🔍 -2% - +3% -15.42ms - +30.03ms
previous-release previous-release	877.84ms - 911.02ms	unsure 🔍 -4% - +2% -31.76ms - +18.29ms	unsure 🔍 -3% - +2% -30.03ms - +15.42ms	-

_{tachometer-reporter-action v2 for Benchmarks}

augustjk

Thanks!

AndrewJakubowicz · 2022-06-27T17:41:50Z

packages/tests/package.json

    "@web/dev-server-legacy": "^0.1.7",
-    "@web/dev-server-rollup": "^0.3.13",
-    "@web/test-runner": "^0.13.22",
+    "@web/dev-server-rollup": "=0.3.15",


I wasn't able to find docs around this syntax. Is this a syntax to pin that exact version? Or a version of "save-exact"?

It means exactly equal: https://github.com/npm/node-semver#ranges

aomarks added 7 commits June 25, 2022 14:17

Upgrade everything

6341826

Pin localize-tools typescript version becuase of new type error

575652b

Pin ts-transformers ts-clone-node version because of unknown breaking…

e759588

… change

Pin ts-transformers typescript version because of new type errors

8b00e61

Update import style for rollup-plugin-summary

6077081

Pin broken @web/test-runner deps

78cfa22

Add changeset

2364ab9

aomarks requested a review from justinfagnani as a code owner June 25, 2022 23:42

aomarks requested review from augustjk and AndrewJakubowicz June 25, 2022 23:42

augustjk approved these changes Jun 27, 2022

View reviewed changes

AndrewJakubowicz reviewed Jun 27, 2022

View reviewed changes

AndrewJakubowicz approved these changes Jun 27, 2022

View reviewed changes

aomarks merged commit 0c9ee0e into main Jun 27, 2022

aomarks deleted the upgrade branch June 27, 2022 17:44

This was referenced Jun 29, 2022

Version Packages #3070

Closed

Version Packages #3106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[infra] Upgrade package locks, and pin some broken deps #3092

[infra] Upgrade package locks, and pin some broken deps #3092

aomarks commented Jun 25, 2022 •

edited

Loading

changeset-bot bot commented Jun 25, 2022

github-actions bot commented Jun 25, 2022 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

augustjk left a comment

AndrewJakubowicz Jun 27, 2022

aomarks Jun 27, 2022

[infra] Upgrade package locks, and pin some broken deps #3092

[infra] Upgrade package locks, and pin some broken deps #3092

Conversation

aomarks commented Jun 25, 2022 • edited Loading

changeset-bot bot commented Jun 25, 2022

🦋 Changeset detected

github-actions bot commented Jun 25, 2022 • edited Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

augustjk left a comment

Choose a reason for hiding this comment

AndrewJakubowicz Jun 27, 2022

Choose a reason for hiding this comment

aomarks Jun 27, 2022

Choose a reason for hiding this comment

aomarks commented Jun 25, 2022 •

edited

Loading

github-actions bot commented Jun 25, 2022 •

edited

Loading