fix: remove unsafe-eval (CSP volation) #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 32 32
Lines 2761 2761
=======================================
Hits 1844 1844
Misses 917 917 Continue to review full report at Codecov.
|
surunzi
added a commit
that referenced
this pull request
May 2, 2020
|
util.js file can not be modified since it is generated by https://github.com/liriliri/eustia. |
|
Thanks, is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eruda fails to load on sites that block eval (Function constructor).
I couldn't find a reason for this function to be using eval, so I've simplified it.
I also converted it to use ES2015 rest / spread.
The only effect of this change I found is one less line in stack trace (if contructor throws).