Added additional verification for GenerateChangelogTest #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ class GenerateChangelogTest extends Specification { | |||
| @Shared | |||
| UIService uiService = Scope.getCurrentScope().getUI() | |||
| String testResourcesPath = System.getProperty("user.dir") + "/src/test/resources/" | |||
| String generatedResourcesPath = "/src/test/resources/" | |||
There was a problem hiding this comment.
plz change to something like
String resourcesDirPath = "/src/test/resources/"
String resourcesDirFullPath = System.getProperty("user.dir") + resourcesDirPath
There was a problem hiding this comment.
let's either have 4 properties
String xmlChangelogPath
String sqlChangelogPath
String yamlChangelogPath
String jsonChangelogPath
or only base path
as
map.put("expectedYmlChangelog", testInput.xmlChangelogPath.replace(".xml", ".yml"))
map.put("expectedJsonChangelog", testInput.xmlChangelogPath.replace(".xml", ".json"))
is confusing
| @@ -28,7 +28,7 @@ class GenerateChangelogTestHelper { | |||
| for (DatabaseUnderTest databaseUnderTest : databaseConnectionUtil | |||
| .initializeDatabasesConnection(TestConfig.instance.getFilteredDatabasesUnderTest())) { | |||
| for (def changeLogEntry : FileUtils.resolveInputFilePaths(databaseUnderTest, baseChangelogPath + | |||
| "expectedChangeLog", "sql").entrySet()) { | |||
| "expectedChangeLog", "xml").entrySet()) { | |||
There was a problem hiding this comment.
can we use TestConfig.instance.inputFormat here? Or maybe we can change to build testInput in other way as we don't really pick up only files with this extension
KushnirykOleh
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.