Fixes include/excludeObjects filters for the 'generate-changelog' command specifically for the maven plugin #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evan-Christensen
temporarily deployed
to
external
GitHub Actions
Inactive
Evan-Christensen
had a problem deploying
to
external
GitHub Actions
Failure
|
@Evan-Christensen thanks for filing this PR! We'll take a look and review as soon as we can. |
filipelautert
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Makes sense @Evan-Christensen , thanks for the fix!
For CommandLine it is working as it parses INCLUDE_OBJECTS_ARG and EXCLUDE_OBJECTS_ARG, so this is really a maven fix only.
tati-qalified
approved these changes
Oct 14, 2024
filipelautert
requested a deployment
to
external
GitHub Actions
Waiting
rberezen
approved these changes
Oct 21, 2024
tati-qalified
temporarily deployed
to
external
GitHub Actions
Inactive
tati-qalified
requested a deployment
to
external
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fixes #5902
Hey all. I just figured I'd submit a quick bugfix for this issue I submitted back in May. It just adds the filter to the command scope so the supplied include/excludeObjects parameters get applied.
Apologies in advance if this PR is missing anything important, as this is my first Liquibase change.
Things to be aware of
This function only seems to be used by the Maven plugin.