-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lombok getter and setter. #5766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloD12
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Build and tests have been successfully executed.
filipelautert
approved these changes
Apr 30, 2024
# Conflicts: # liquibase-standard/src/main/java/liquibase/integration/ant/DBDocTask.java # liquibase-standard/src/main/java/liquibase/integration/ant/DropAllTask.java # liquibase-standard/src/main/java/liquibase/integration/ant/TagDatabaseTask.java
rberezen
approved these changes
May 9, 2024
# Conflicts: # liquibase-standard/src/main/java/liquibase/lockservice/DatabaseChangeLogLock.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Similar to #5658, this PR users Lombok getters and setters.
Things to be aware of
All changes were done automatically by IntelliJ.
Only the methods without JavaDoc were included, as it seems there are bugs in IntelliJ to handle
@param
or@return
, or for overloaded setters, which would be reported to JetBrains.An exception is the removal of the JavaDoc of CreateIndexChange.unique, as I think it doesn't add much value.
Things to worry about
Additional Context