Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lombok getter and setter. #5766

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Use lombok getter and setter. #5766

merged 12 commits into from
Jun 13, 2024

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Apr 4, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Similar to #5658, this PR users Lombok getters and setters.

Things to be aware of

All changes were done automatically by IntelliJ.

Only the methods without JavaDoc were included, as it seems there are bugs in IntelliJ to handle @param or @return, or for overloaded setters, which would be reported to JetBrains.

An exception is the removal of the JavaDoc of CreateIndexChange.unique, as I think it doesn't add much value.

Things to worry about

Additional Context

@asashour asashour requested a review from filipelautert as a code owner April 4, 2024 09:40
@MalloD12 MalloD12 self-assigned this Apr 17, 2024
@MalloD12 MalloD12 self-requested a review April 17, 2024 18:25
Copy link
Collaborator

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Build and tests have been successfully executed.

# Conflicts:
#	liquibase-standard/src/main/java/liquibase/integration/ant/DBDocTask.java
#	liquibase-standard/src/main/java/liquibase/integration/ant/DropAllTask.java
#	liquibase-standard/src/main/java/liquibase/integration/ant/TagDatabaseTask.java
# Conflicts:
#	liquibase-standard/src/main/java/liquibase/lockservice/DatabaseChangeLogLock.java
@filipelautert filipelautert merged commit 73af9a0 into liquibase:master Jun 13, 2024
33 of 34 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Jun 13, 2024
@asashour asashour deleted the lombok branch June 14, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants