fix: addColumn changes are not respecting Datatypes definitions #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
changed the title
MalloD12
reviewed
Mar 13, 2024
...tandard/src/main/java/liquibase/diff/output/changelog/core/MissingColumnChangeGenerator.java
Show resolved
Hide resolved
rberezen
approved these changes
Mar 21, 2024
MalloD12
approved these changes
Mar 21, 2024
filipelautert
force-pushed
the
fix-addcolumn-types
branch
from
814d371 to
8dbf990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
When running a diffChangelog, a create table the column uses the Datatypes classes to define the column types, but an addColumn change would simply dump the database text.
This PR fixes addColumn by making it behave as createTable.