SQL Anywhere: Recompile all views after last change of update #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Sep 5, 2023
rberezen
approved these changes
Sep 5, 2023
liquibase-standard/src/main/java/liquibase/command/core/AbstractUpdateCommandStep.java
Show resolved
Hide resolved
# Conflicts: # liquibase-standard/src/main/java/liquibase/database/Database.java
filipelautert
approved these changes
Oct 30, 2023
Signed-off-by: filipe <flautert@liquibase.org>
|
Kudos, SonarCloud Quality Gate passed! |
|
@mkarg I did a small refactoring to use the already existing sql executor method instead of creating a new one - could you confirm if it's fine for you? Then I'll get it merged for next release. |
LGTM. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Fixes #4575
Description
The solution for #4575 simply is to execute the command
sa_recompile_views(1)(see SAP SQL Anywhere Manual) once after the very last change was executed byupdate, which is exactly the same command that the original native tools from SAP execute to resolve this situation. This command never induces any risk, so unconditional execution is no problem in any case (which is why SAP's native tools do execute it unconditionaly).Things to be aware of
To make the code a little cleaner I extended the
Databaseinterface by a newdefaultmethod, i. e. it implies no harm to existing code, but it opens the possibility for all RDBMS to execute some useful code in similar situations.Things to worry about
Despite the causeless warning in the SAP manual, as this is exactly the original solution applied by the original native SAP tools, there is absolutely nothing to worry about.
Additional Context
N/A