Update SnakeYAML usage - do not call deprecated methods #3632

asomov · 2022-12-30T12:45:22Z

Deprecated methods might be removed in the next SnakeYAML major release.
Dumper and Loader options are shared and reused.

…e removed

nvoxland · 2023-01-02T20:10:23Z

Initial/Pre-Review Thoughts

Looks like just fixing up how snakeyaml is called. Thanks for the fix!

Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing

asomov · 2023-01-03T05:26:41Z

Most probably, the deprecated methods will be removed in the next release of SnakeYAML

# Conflicts: # liquibase-core/src/main/java/liquibase/serializer/core/yaml/YamlSnapshotSerializer.java

asomov · 2023-01-09T09:51:10Z

latest changes were added

…nakeyaml

asomov · 2023-01-20T05:59:26Z

@MalloD12 SnakeYAML will be released most probably in Feb 2023 with the deprecated methods removed.

…into asomov-update-snakeyaml

MalloD12

Approved.

Review and testing results:

Update SnakeYaml called methods to avoid using deprecated methods looks good. Build and our existent test which makes use of these changes are all passing.

Things to be aware of:

As @asomov mentioned deprecated methods will be removed from next SnakeYaml version, but no extra changes is require for us.

Things to worry about:

None

github-actions · 2023-01-20T19:12:05Z

Unit Test Results

  5 278 files ±  0   5 278 suites ±0 33m 33s ⏱️ - 2m 13s
  4 858 tests - 18   4 636 ✔️ - 21   222 💤 +3 0 ❌ ±0
62 322 runs - 12 56 280 ✔️ - 17 6 042 💤 +5 0 ❌ ±0

Results for commit b34bf43. ± Comparison against base commit 0b20257.

♻️ This comment has been updated with latest results.

asomov · 2023-02-06T16:14:50Z

@MalloD12 what can I do to fix/merge this PR ?

MalloD12 · 2023-02-10T21:47:57Z

@MalloD12 what can I do to fix/merge this PR ?

My apologies @asomov it was my mistake to not move this PR to "code review" in our board so other members of the team can review it as well. Doing it now!

XDelphiGrl · 2023-02-15T13:32:55Z

liquibase-core/src/main/java/liquibase/parser/core/yaml/YamlParser.java


 public abstract class YamlParser implements LiquibaseParser {

    protected Logger log = Scope.getCurrentScope().getLog(getClass());

+    public static LoaderOptions createLoaderOptions() {


How was it determined which defaults to use in the LoaderOptions setters? We've seen some issues around code point limit recently and although MAX_VALUE seems to make sense, I want to double-check with all the Devs out there.

CC @asomov @MalloD12

Older versions of SnakeYaml do not have the ability to set a code point limit, If for some reason if older version of snakeyaml is loaded then this would thrown an error. It is safe to catch NoSuchMethodError. We have a method that serves the purpose in SnakeYamlUtil class which will be releasing in 4.19.1
@filipelautert

Updating setCodePointLimitSafely() call by using the one defined in SnakeYamlUtil.

Thanks for making that change, @MalloD12!

suryaaki2 · 2023-02-15T13:42:57Z

liquibase-core/src/main/java/liquibase/parser/core/yaml/YamlParser.java


 public abstract class YamlParser implements LiquibaseParser {

    protected Logger log = Scope.getCurrentScope().getLog(getClass());

+    public static LoaderOptions createLoaderOptions() {


Older versions of SnakeYaml do not have the ability to set a code point limit, If for some reason if older version of snakeyaml is loaded then this would thrown an error. It is safe to catch NoSuchMethodError. We have a method that serves the purpose in SnakeYamlUtil class which will be releasing in 4.19.1
@filipelautert

asomov · 2023-02-15T14:50:45Z

the limit helps to prevent at attack when a huge file is provided to overload the server. SnakeYAML has some reports on wrong input.
The limit should be enough to cover all the use cases. Feel free to set any value. The limit does not affect anything when the YAML file is trusted

asomov · 2023-02-16T08:34:36Z

@suryaaki2 what is expected to be changed ?

filipelautert · 2023-02-16T16:43:36Z

Hello @asomov! Regarding @suryaaki2 comment, there is another PR (#3807) that will handle code point limit for SnakeYaml . Once we merge it, we can update your branch and make sure that both are working fine together.

…yaml

…YamlUtil.

…into asomov-update-snakeyaml

XDelphiGrl

In preparation for the biannual SnakeYAML release, this PR removes usage of deprecated constructors and methods.
SnakeYAML Deprecation List
Relevant SnakeYAML Commit for Deprecated Constructors

Functional tests passing.
Test harness failures due to an environmental issue related to Titan; these can be safely ignored.
No additional testing required.

APPROVED

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.200.0` -> `^0.201.0`](https://renovatebot.com/diffs/npm/flow-bin/0.200.0/0.201.0) | | [org.liquibase:liquibase-maven-plugin](http://www.liquibase.org/liquibase-maven-plugin) ([source](https://github.com/liquibase/liquibase)) | build | patch | `4.19.0` -> `4.19.1` | | [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.33.0` -> `2.34.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.16.3.Final` -> `2.16.4.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.16.3.Final` -> `2.16.4.Final` | | [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.10.1` -> `3.11.0` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.201.0`](flow/flow-bin@d54e283...86aea9c) [Compare Source](flow/flow-bin@d54e283...86aea9c) ### [`v0.200.1`](flow/flow-bin@b6c1eb0...d54e283) [Compare Source](flow/flow-bin@b6c1eb0...d54e283) </details> <details> <summary>liquibase/liquibase</summary> ### [`v4.19.1`](https://github.com/liquibase/liquibase/releases/tag/v4.19.1) [Compare Source](liquibase/liquibase@v4.19.0...v4.19.1) ##### Liquibase v4.19.1 is a patch release #### Enhancements - Publish liquibase-extension-testing to github packages (DAT-12833) by [@abrackx](https://github.com/abrackx) in liquibase/liquibase#3697 - Add support for multiple schemas to dbDoc command by [@zpanderson](https://github.com/zpanderson) in liquibase/liquibase#1834 - No need redundant conditions. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3553 - Replace expressions with type arguments with diamond type <>. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3591 - Remove duplicate conditions in expressions and branches of if statements. They are used due to oversight. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3548 - Replace constant charset String literal with the predefined StandardC… by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3568 - Normalize path of SQL changelog file when parsing (DAT-11891) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3664 - Delegate change set equality tests by [@droy-sandbox](https://github.com/droy-sandbox) in liquibase/liquibase#3550 - (DAT-6636)Refactor of TagExistsCommandStep and extraction of code to new LockServiceCommandStep by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3667 - Refactors CalculateChecksumCommandStep by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3696 - CORE-3044 avoid locking if no updates pending by [@RichardBradley](https://github.com/RichardBradley) in liquibase/liquibase#2190 - Warning in case of missing liquibase files instead of throwing an exception by [@mhewedy](https://github.com/mhewedy) in liquibase/liquibase#3081 - Remove redundant modifiers. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3594 - Update maven-bundle-plugin instructions to export package containing XSD files by [@GeertZondervan](https://github.com/GeertZondervan) in liquibase/liquibase#3597 - Remove redundant conditions that covered by a subsequent condition. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3590 - Add support for db2 view comments (DAT-12529) by [@abrackx](https://github.com/abrackx) in liquibase/liquibase#3723 - Remove unnecessary cast expressions. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3670 - Performance improvements by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3588 - Implemented a summary of change sets which get filtered out during update (DAT-12068) by [@wwillard7800](https://github.com/wwillard7800) in liquibase/liquibase#3730 - Support tabular format for history command by [@fbiville](https://github.com/fbiville) in liquibase/liquibase#3541 - Remove Unnecessary operation/modifier: by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3657 - Update and rename bug_report.md to bug_report.yaml by [@kevin-atx](https://github.com/kevin-atx) in liquibase/liquibase#3728 - Improve command line help message format by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3829 - Use StandardCharsets constant instead. (DAT-12853) by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3725 - Update SnakeYAML usage - do not call deprecated methods by [@asomov](https://github.com/asomov) in liquibase/liquibase#3632 - Avoid global mutable state of Non-final fields in enumeration types. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3727 - Use constants instead of arrays with known lengths of zero by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3716 - Simplify lambda expressions when possible by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3736 - \[MRO] Added new modifyChangeSets tag to support specification of `runWith` attribute for all change sets in `include` or `includeAll` - \[MRO] DAT-7922 Implement a check for one change per changeset by [@wwillard7800](https://github.com/wwillard7800) in https://github.com/liquibase/liquibase-pro/pull/790 - \[MRO] DAT-11915 Correctly escape SQL to enable and disable triggers on PostgreSQL by [@wwillard7800](https://github.com/wwillard7800) in https://github.com/liquibase/liquibase-pro/pull/799 - \[MRO] DAT-10157: add database scope for reserved words checks by [@StevenMassaro](https://github.com/StevenMassaro) in https://github.com/liquibase/liquibase-pro/pull/802 - \[MRO] DAT-13189 safely set code point limit for SnakeYaml by [@StevenMassaro](https://github.com/StevenMassaro) in https://github.com/liquibase/liquibase-pro/pull/827 - \[MRO] DAT-13440: show changesetsRolledback only after rollback is complete by [@StevenMassaro](https://github.com/StevenMassaro) in https://github.com/liquibase/liquibase-pro/pull/838 - \[MRO] DAT-12568 by [@jnewton03](https://github.com/jnewton03) in https://github.com/liquibase/liquibase-pro/pull/844 #### Fixes - Fixes generate-changelog table/view comment and table/view column comment generation for MSSQL (DAT-12045) by [@abrackx](https://github.com/abrackx) in liquibase/liquibase#3563 - Fully qualified path to the changelog or snapshot in S3 is not allowed, so needs better msg (DAT-11478) by [@diadiushko](https://github.com/diadiushko) in liquibase/liquibase#3564 - (DAT-12039) :detect circular references in includeAll statement by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3695 - improve logging around paths that do not exist (DAT-12038) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3669 - normalize path of json and yaml changelogs when parsing (DAT-11891) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3711 - deprecate DefaultLoggerConfiguration (DAT-11970) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3706 - Rework dropProcedure for Snowflake Log message when dropAll fails (DAT-12916) by [@wwillard7800](https://github.com/wwillard7800) in liquibase/liquibase#3702 - fix: snowflake has wrong priority by [@Yogurt-lei](https://github.com/Yogurt-lei) in liquibase/liquibase#3572 - Do not add default schema name to getSchemas method to avoid one schema by [@LonwoLonwo](https://github.com/LonwoLonwo) in liquibase/liquibase#3704 - [#3035](liquibase/liquibase#3035) add Double data type class to avoid incorrect double(0) database by [@LonwoLonwo](https://github.com/LonwoLonwo) in liquibase/liquibase#3703 - Stop publishing liquibase-extension-testing to Github on branch builds (DAT-13038) by [@abrackx](https://github.com/abrackx) in liquibase/liquibase#3726 - do not support setting column comments on a view in Snowflake (DAT-12530) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3710 - Fix NullPointerException for case sensitive collations by [@ivan909020](https://github.com/ivan909020) in liquibase/liquibase#3699 - (DAT-13269) pass proper branch name and add required field by [@jnewton03](https://github.com/jnewton03) in liquibase/liquibase#3765 - Consistent ARG-suffix for 'defaultSchemaName'-Parameter by [@SIEDA-EliasHeydrich](https://github.com/SIEDA-EliasHeydrich) in liquibase/liquibase#3662 - Removing explicit LiquibaseServletListener references by [@Thunderforge](https://github.com/Thunderforge) in liquibase/liquibase#3677 - Add Snowflake structured data types to unmodifiable Data Types by [@LonwoLonwo](https://github.com/LonwoLonwo) in liquibase/liquibase#3752 - Fix [#3690](liquibase/liquibase#3690) primaryKeyExists does not work on DB2z by [@MichaelKern-IVV](https://github.com/MichaelKern-IVV) in liquibase/liquibase#3691 - Replace old stream creation with java.nio. by [@arturobernalg](https://github.com/arturobernalg) in liquibase/liquibase#3686 - github-action (DAT-13527) by [@jnewton03](https://github.com/jnewton03) in liquibase/liquibase#3827 - Do not duplicate clearCheckSums logic by [@fbiville](https://github.com/fbiville) in liquibase/liquibase#3628 - Fixing [#3708](liquibase/liquibase#3708) - AddColumn fix for H2 version 1.4.200 by [@KarolyNevelos](https://github.com/KarolyNevelos) in liquibase/liquibase#3709 - Added default values to private Scope constructor by [@MarkTJohnson](https://github.com/MarkTJohnson) in liquibase/liquibase#3756 - Improved concurrency support by using ConcurrentHashMaps by [@jurgenkleverwal](https://github.com/jurgenkleverwal) in liquibase/liquibase#3799 - fixing lookahead for last line comment method by [@mwiede](https://github.com/mwiede) in liquibase/liquibase#3717 - Do not calculate checksum when loading changelogs by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3790 - set up maven using simpler GitHub action by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3835 - safely set code point limit for SnakeYaml (DAT-13189) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3807 - Fix failing EnvironmentValueProviderTest by [@nvoxland](https://github.com/nvoxland) in liquibase/liquibase#3783 - show changesetsRolledback only after rollback is complete (DAT-13440) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3846 #### Security, Driver and other updates **OWASP Dependency Check: Reported Vulnerabilities** `snakeyaml.jar` - This is a "critical" vulnerability reported against the snakeyaml library. Note: Liquibase code is not vulnerable to this attack, but users can manually upgrade to the newest version of snakeyaml library, and will be upgraded to the unaffected snakeyaml 2.0 version in the next release. If you are interested, you can track the MR at liquibase/liquibase#3865 - Bump junit-jupiter-params from 5.9.1 to 5.9.2 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3673 - Bump ant from 1.10.11 to 1.10.13 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3672 - Bump firebird-testcontainers-java from 1.2.0 to 1.3.0 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3653 - Bump actions/delete-package-versions from 3 to 4 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3649 - Bump maven-plugin-plugin from 3.7.0 to 3.7.1 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3698 - Bump assertj-core from 3.23.1 to 3.24.2 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3705 - Bump jaybird from 4.0.8.java8 to 5.0.0.java8 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3659 - Bump mariadb-java-client from 3.1.0 to 3.1.2 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3729 - Bump snowflake-jdbc from 3.13.26 to 3.13.27 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3751 - Bump picocli from 4.7.0 to 4.7.1 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3742 - Bump actions/cache from 3.2.3 to 3.2.4 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3750 - Bump actions/cache from 3.2.4 to 3.2.5 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3809 - Bump maven-deploy-plugin from 3.0.0 to 3.1.0 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3802 - Bump maven-shade-merge-manifest-transformer from 0.0.2 to 0.0.3 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3779 - Bump postgresql from 42.5.1 to 42.5.3 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3778 - Bump jaxb-runtime from 4.0.1 to 4.0.2 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3786 - Bump jaxb-core from 4.0.1 to 4.0.2 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3787 - Bump sqlite-jdbc from 3.40.0.0 to 3.40.1.0 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3772 - Bump maven-enforcer-plugin from 3.1.0 to 3.2.1 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3759 - Bump jaybird from 5.0.0.java8 to 5.0.1.java8 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3760 - Bump mssql-jdbc from 11.2.1.jre8 to 12.2.0.jre8 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3761 - Bump ojdbc8 from 21.8.0.0 to 21.9.0.0 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3808 - Bump postgresql from 42.5.3 to 42.5.4 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3831 - Migrate setup-java action to use Temurin by [@gdams](https://github.com/gdams) in liquibase/liquibase#3607 #### New Contributors - [@zpanderson](https://github.com/zpanderson) made their first contribution in liquibase/liquibase#1834 - [@droy-sandbox](https://github.com/droy-sandbox) made their first contribution in liquibase/liquibase#3550 - [@mhewedy](https://github.com/mhewedy) made their first contribution in liquibase/liquibase#3081 - [@GeertZondervan](https://github.com/GeertZondervan) made their first contribution in liquibase/liquibase#3597 - [@Yogurt-lei](https://github.com/Yogurt-lei) made their first contribution in liquibase/liquibase#3572 - [@gdams](https://github.com/gdams) made their first contribution in liquibase/liquibase#3607 - [@ivan909020](https://github.com/ivan909020) made their first contribution in liquibase/liquibase#3699 - [@SIEDA-EliasHeydrich](https://github.com/SIEDA-EliasHeydrich) made their first contribution in liquibase/liquibase#3662 - [@Thunderforge](https://github.com/Thunderforge) made their first contribution in liquibase/liquibase#3677 - [@KarolyNevelos](https://github.com/KarolyNevelos) made their first contribution in liquibase/liquibase#3709 - [@MarkTJohnson](https://github.com/MarkTJohnson) made their first contribution in liquibase/liquibase#3756 - [@jurgenkleverwal](https://github.com/jurgenkleverwal) made their first contribution in liquibase/liquibase#3799 - [@mwiede](https://github.com/mwiede) made their first contribution in liquibase/liquibase#3717 **Full Changelog**: liquibase/liquibase@v4.17.2...v4.19.1 ##### Get Certified Learn all the Liquibase fundamentals from free online courses by Liquibase experts and see how to apply them in the real world at https://learn.liquibase.com/. ##### Read the Documentation Please check out and contribute to the continually improving docs, now at https://docs.liquibase.com/. ##### Meet the Community Our community has built a lot. From extensions to integrations, you’ve helped make Liquibase the amazing open source project that it is today. Keep contributing to making it stronger: [Contribute code](https://www.liquibase.org/development/contribute.html) [Make doc updates](https://github.com/Datical/liquibase-docs) [Help by asking and answering questions](https://forum.liquibase.org/) [Set up a chat with the Product team](https://calendly.com/liquibase-outreach/product-feedback) Thanks to everyone who helps make the Liquibase community strong! #### File Descriptions - **Liquibase CLI** -- Includes open source + commercial functionality - **liquibase-x.y.z.tar.gz** -- Archive in tar.gz format - **liquibase-x.y.z.zip** -- Archive in zip format - **liquibase-windows-x64-installer-x.y.z.exe** -- Installer for Windows - **liquibase-macos-installer-x.y.z.dmg** -- Installer for MacOS - **Primary Libraries** - For embedding in other software - **liquibase-core-x.y.z.jar** – Base Liquibase library (open source) - **liquibase-commerical-x.y.z.jar** – Additional commercial functionality - **liquibase-additional-x.y.z.zip** – Contains additional, less commonly used files - Additional libraries such as liquibase-maven-plugin.jar and liquibase-cdi.jar - Javadocs for all the libraries - Source archives for all the open source libraries - ASC/MD5/SHA1 verification hashes for all files **Full Changelog**: liquibase/liquibase@v4.19.0...v4.19.1 </details> <details> <summary>diffplug/spotless</summary> ### [`v2.34.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#2340---2023-01-26) ##### Added - `Formatter` now has a field `public static final File NO_FILE_SENTINEL` which can be used to pass string content to a Formatter or FormatterStep when there is no actual File to format. ([#1525](diffplug/spotless#1525)) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v2.16.4.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.4.Final) [Compare Source](quarkusio/quarkus@2.16.3.Final...2.16.4.Final) ##### Complete changelog - [#31510](quarkusio/quarkus#31510) - Add logging to CompiledJavaVersionBuildStep - [#31507](quarkusio/quarkus#31507) - Adjust API in transaction.adoc code snippet - [#31498](quarkusio/quarkus#31498) - Added a note to get correct OpenAPI documentation - [#31486](quarkusio/quarkus#31486) - smallrye-openapi generates wrong definition for grouped parameters - [#31483](quarkusio/quarkus#31483) - Fix documentation for quarkus.hibernate-orm.enabled - [#31477](quarkusio/quarkus#31477) - Qute generated value resolvers - fix varArgs methods with 1 argument - [#31471](quarkusio/quarkus#31471) - \[2.16] Make sure parent modules are loaded into workspace before those that depend on them - [#31467](quarkusio/quarkus#31467) - Don't run kubernetes-client Dev Services transitively - [#31465](quarkusio/quarkus#31465) - Propagate Quarkus related failsafe system properties - [#31462](quarkusio/quarkus#31462) - Do not append single '&' with empty query params in Resteasy Reactive - [#31449](quarkusio/quarkus#31449) - Qute: VarArgs processing error with 1 element - [#31447](quarkusio/quarkus#31447) - SmallRye GraphQL 1.9.3, test for Deprecated annotation - [#31422](quarkusio/quarkus#31422) - Fix client jackson body writer to propagate the client context - [#31418](quarkusio/quarkus#31418) - Fix doc generation for quarkus.hibernate-orm.enabled - [#31416](quarkusio/quarkus#31416) - Fix copy paste error in qute docs - [#31405](quarkusio/quarkus#31405) - Propagate SystemProperties set in Failsafe plugin to the Test launcher - [#31394](quarkusio/quarkus#31394) - Fix afterEach callback for integration tests - [#31393](quarkusio/quarkus#31393) - Integration Test AfterEach callbacks are not called - [#31355](quarkusio/quarkus#31355) - \[Regression] Very slow startup in dev mode when the Kubernetes extension is present - [#31350](quarkusio/quarkus#31350) - Also set io.netty.noUnsafe at runtime when set at build time - [#31349](quarkusio/quarkus#31349) - Netty complaining about access to heap buffer in native - [#31347](quarkusio/quarkus#31347) - Adjust image name substitution for Elasticsearch Dev Services - [#31339](quarkusio/quarkus#31339) - Improve logging in DevServicesKubernetesProcessor - [#31336](quarkusio/quarkus#31336) - Pass `--userns=keep-id` to podman only when in rootless mode - [#31331](quarkusio/quarkus#31331) - Use idiomatic RESTEasy Reactive filter declaration for OpenTelemetry - [#31316](quarkusio/quarkus#31316) - Improve CSRF documentation - [#31302](quarkusio/quarkus#31302) - Updated OpenAPI `mp.openapi.extensions.smallrye.openapi` key mapping - [#31300](quarkusio/quarkus#31300) - Support UUID serialization in REST Client multipart bodies - [#31298](quarkusio/quarkus#31298) - RESTEasy Reactive doesn't support `java.util.UUID` - [#31291](quarkusio/quarkus#31291) - Bump `org.jetbrains.annotations` from `17.0.0` to the latest(`24.0.0`) - [#31289](quarkusio/quarkus#31289) - Return a null InputStream from REST Client when response is 204 - [#31280](quarkusio/quarkus#31280) - Bump SQL Server JDBC driver to 12.2.0 - [#31276](quarkusio/quarkus#31276) - Bump protobuf from 3.21.9 to 3.22.0 - [#31274](quarkusio/quarkus#31274) - Try to solve disk space issues on GitHub Actions - [#31261](quarkusio/quarkus#31261) - Bump Microsoft SQL Server JDBC driver to 12.2.0 - [#31260](quarkusio/quarkus#31260) - Make OIDC connection error log messages more visible - [#31250](quarkusio/quarkus#31250) - Clarify in keycloak-authorization doc when it should be used - [#31249](quarkusio/quarkus#31249) - Empty array of values in WebTargetImpl.queryParam method is added to the final URI as an `&` - [#31245](quarkusio/quarkus#31245) - \[Regression in 2.16.3] `NullPointerException: Cannot invoke "org.jboss.resteasy.reactive.server.SimpleResourceInfo.getResourceClass()" because "this.resourceInfo" is null` - [#31240](quarkusio/quarkus#31240) - protobuf code generated w/ 3.22.0 broken w/ Quarkus - [#31236](quarkusio/quarkus#31236) - Bump postgresql from 42.5.3 to 42.5.4 - [#31234](quarkusio/quarkus#31234) - Bump mermaid from 9.1.1 to 9.4.0 - [#31231](quarkusio/quarkus#31231) - RESTEasy reactive returns an empty InputStream instead of null on 204 - No Content response - [#31211](quarkusio/quarkus#31211) - Fix the non-default constructor mechanism of bytecode recording \[2.16] - [#31209](quarkusio/quarkus#31209) - Another fix for the Redis Search aggregation test - [#31186](quarkusio/quarkus#31186) - Show how to enable all origins in HTTP CORS section - [#31150](quarkusio/quarkus#31150) - Add keycloak authorization capability - [#31127](quarkusio/quarkus#31127) - Enhancements to instructions for contributing to the Quarkus docs - [#31334](quarkusio/quarkus#31334) - podman4 can't build any code with quarkus builder - [#30601](quarkusio/quarkus#30601) - Generate a preview website for documentation MRs - [#30549](quarkusio/quarkus#30549) - Enhancements and fixes for the Authorization of Web Endpoints section - [#30419](quarkusio/quarkus#30419) - Enhancing the Authorization of Web endpoints guide - [#30333](quarkusio/quarkus#30333) - Can't work with Google Oauth2 using qaurkus-oidc - [#29427](quarkusio/quarkus#29427) - quarkus.oidc.auth-server-url causing weird start-up failure - [#26152](quarkusio/quarkus#26152) - Resteasy Reactive: ContextResolver<ObjectMapper> not used </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.16.4.Final`](quarkusio/quarkus-platform@2.16.3.Final...2.16.4.Final) [Compare Source](quarkusio/quarkus-platform@2.16.3.Final...2.16.4.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Update SnakeYAML usage - do not call deprecated methods, they might b…

78a5763

…e removed

asomov requested a review from filipelautert as a code owner December 30, 2022 12:45

Merge branch 'master' into update-snakeyaml

247b264

# Conflicts: # liquibase-core/src/main/java/liquibase/serializer/core/yaml/YamlSnapshotSerializer.java

MalloD12 self-requested a review January 19, 2023 21:46

MalloD12 self-assigned this Jan 19, 2023

MalloD12 added sprint2023-43 labels Jan 19, 2023

Merge branch 'master' of github.com:liquibase/liquibase into update-s…

886600b

…nakeyaml

Merge branch 'update-snakeyaml' of https://github.com/asomov/liquibase …

771c0e2

…into asomov-update-snakeyaml

MalloD12 approved these changes Jan 20, 2023

View reviewed changes

Merge branch 'master' into update-snakeyaml

5c66969

MalloD12 added the SafeToBuild label Jan 20, 2023

MalloD12 added SafeToBuild and removed SafeToBuild labels Jan 20, 2023

MalloD12 removed the SafeToBuild label Feb 10, 2023

Merge branch 'master' into update-snakeyaml

8fbcbf7

MalloD12 added the SafeToBuild label Feb 10, 2023

suryaaki2 approved these changes Feb 13, 2023

View reviewed changes

XDelphiGrl reviewed Feb 15, 2023

View reviewed changes

suryaaki2 requested changes Feb 15, 2023

View reviewed changes

MalloD12 added 3 commits February 21, 2023 11:31

Merge remote-tracking branch 'origin/master' into asomov-update-snake…

8ca14db

…yaml

Update setCodePointLimitSafely to make use of defined method in Snake…

e508a1b

…YamlUtil.

Merge branch 'update-snakeyaml' of https://github.com/asomov/liquibase …

b34bf43

…into asomov-update-snakeyaml

MalloD12 added SafeToBuild and removed SafeToBuild labels Feb 21, 2023

filipelautert approved these changes Feb 22, 2023

View reviewed changes

filipelautert requested review from suryaaki2 and XDelphiGrl February 22, 2023 17:20

XDelphiGrl approved these changes Feb 22, 2023

View reviewed changes

suryaaki2 approved these changes Feb 22, 2023

View reviewed changes

Merge branch 'master' into update-snakeyaml

b4acc4f

filipelautert added SafeToBuild and removed SafeToBuild labels Feb 22, 2023

filipelautert merged commit a2d368e into liquibase:master Feb 22, 2023

filipelautert added this to the 1NEXT milestone Feb 22, 2023

asomov deleted the update-snakeyaml branch February 23, 2023 09:26

freddiN mentioned this pull request Mar 1, 2023

SnakeYaml "NoSuchMethod" issue after updating to 4.19.1 #3878

Closed

2 tasks

filipelautert mentioned this pull request Mar 1, 2023

replace remaining uses of snakeyaml Yaml(new Constructor(), ...) with SafeConstructor #3617

Closed

filipelautert linked an issue Mar 1, 2023 that may be closed by this pull request

replace remaining uses of snakeyaml Yaml(new Constructor(), ...) with SafeConstructor #3617

Closed

filipelautert mentioned this pull request Mar 10, 2023

Rollback Snakeyaml default config to allow duplicate keys. #3939

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SnakeYAML usage - do not call deprecated methods #3632

Update SnakeYAML usage - do not call deprecated methods #3632

asomov commented Dec 30, 2022 •

edited

Loading

nvoxland commented Jan 2, 2023

asomov commented Jan 3, 2023

asomov commented Jan 9, 2023

asomov commented Jan 20, 2023

MalloD12 left a comment

github-actions bot commented Jan 20, 2023 •

edited

Loading

asomov commented Feb 6, 2023

MalloD12 commented Feb 10, 2023

XDelphiGrl Feb 15, 2023

suryaaki2 Feb 15, 2023 •

edited

Loading

MalloD12 Feb 21, 2023

XDelphiGrl Feb 22, 2023

suryaaki2 Feb 15, 2023 •

edited

Loading

asomov commented Feb 15, 2023

asomov commented Feb 16, 2023 •

edited

Loading

filipelautert commented Feb 16, 2023

XDelphiGrl left a comment

Update SnakeYAML usage - do not call deprecated methods #3632

Update SnakeYAML usage - do not call deprecated methods #3632

Conversation

asomov commented Dec 30, 2022 • edited Loading

nvoxland commented Jan 2, 2023

asomov commented Jan 3, 2023

asomov commented Jan 9, 2023

asomov commented Jan 20, 2023

MalloD12 left a comment

Choose a reason for hiding this comment

Review and testing results:

Things to be aware of:

Things to worry about:

github-actions bot commented Jan 20, 2023 • edited Loading

Unit Test Results

asomov commented Feb 6, 2023

MalloD12 commented Feb 10, 2023

XDelphiGrl Feb 15, 2023

Choose a reason for hiding this comment

suryaaki2 Feb 15, 2023 • edited Loading

Choose a reason for hiding this comment

MalloD12 Feb 21, 2023

Choose a reason for hiding this comment

XDelphiGrl Feb 22, 2023

Choose a reason for hiding this comment

suryaaki2 Feb 15, 2023 • edited Loading

Choose a reason for hiding this comment

asomov commented Feb 15, 2023

asomov commented Feb 16, 2023 • edited Loading

filipelautert commented Feb 16, 2023

XDelphiGrl left a comment

Choose a reason for hiding this comment

asomov commented Dec 30, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

suryaaki2 Feb 15, 2023 •

edited

Loading

suryaaki2 Feb 15, 2023 •

edited

Loading

asomov commented Feb 16, 2023 •

edited

Loading