Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used Microsoft's MemoryCache implementation for purging cached queries. #1491

Closed
wants to merge 5 commits into from

Conversation

sdanyliv
Copy link
Member

Given implementation should purge items from cache if they are not used more than 1 hour (configurable).

/// Specifies timeout when query will be evicted from cache since last execution of query.
/// Default value is 1 hour.
/// </summary>
public static TimeSpan CacheSlidingExpiration = TimeSpan.FromHours(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we also can add max size option. Maybe it makes sense to expose it so users could manage cache based on size instead of time or combine both.

@MaceWindu MaceWindu added this to the 2.7.0 milestone Jan 5, 2019
@MaceWindu
Copy link
Contributor

already merged as part of #1587

@MaceWindu MaceWindu closed this Apr 3, 2019
@MaceWindu MaceWindu deleted the cache_improvements branch April 6, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants