Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1144 fixes #1346

Merged
merged 5 commits into from
Oct 25, 2018
Merged

Issue 1144 fixes #1346

merged 5 commits into from
Oct 25, 2018

Conversation

MaceWindu
Copy link
Contributor

@MaceWindu MaceWindu commented Oct 14, 2018

Fixes #1144

  • moved generic arguments list in T4 model from Name to separate GenericArguments field for Method and Class
  • fixed double column selection when column used in index with desctiption on both column and index

…and Method to avoid invalid names generation for duplicate names
@MaceWindu MaceWindu added this to the 2.5.0 milestone Oct 14, 2018
@MaceWindu MaceWindu changed the title [WIP] Issue 1144 fixes Issue 1144 fixes Oct 14, 2018
@@ -231,6 +231,7 @@ static Action<GeneratedTextTransformation> WriteEndClass = tt => tt.WriteLine("}
public partial class Class : TypeBase
{
public string BaseClass;
public string GenericArguments;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to hold here list of types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MaceWindu MaceWindu merged commit ef59f08 into master Oct 25, 2018
@MaceWindu MaceWindu deleted the issue_1144 branch October 25, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

T4 SqlServer failed when exist index description
2 participants