-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Add support for Images Gen. 2 #526
new: Add support for Images Gen. 2 #526
Conversation
36b2a93
to
ddabaec
Compare
@@ -21,3 +21,5 @@ | |||
vendor/**/ | |||
.env | |||
coverage.txt | |||
|
|||
go.work.sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a part of this PR, I dropped the Go workspace sum file from the source tree because it was constantly triggering unexpected diffs and seems to be machine-dependent. If anyone feels I should revert this or break it out into a separate PR, definitely let me know 🙂
@yec-akamai Thanks for the feedback! I split up the ImageStatus and ImageRegionStatus types/consts and they should now match the API implementations 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, things work as expected!
* new: Add support for Images Gen. 2 (#526) * WIP oops * Add unit test case * Drop go.work.sum from source tree * oops * Add tags to ImageUploadOptions * Separate ImageStatus from ImageRegionStatus * Fix tests; add WaitForImageRegionStatus * image replication test with upload image; use getRegionsWithCaps when available * modified replication tests to use uploaded image; use random regions when available * fix fixtures * clean up * sanitize fixture * revert ipv6 pool fixture change --------- Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
📝 Description
This pull request adds support for the Images Gen. 2 project, including the following changes:
tags
field in Image, ImageCreateOptions, ImageUpdateOptions, and ImageCreateUploadOptions structstotal_size
field in Image structregions
field in Image structClient{}.ReplicateImage(...)
endpoint method (/images/{image_id}/regions
)✔️ How to Test
The following test steps assume you have pulled down this PR locally and pointed your local environment to an API instance where Images Gen. 2 is available:
Integration Testing
Unit Testing
Manual Testing
The following test steps are expected to be run in a linodego sandbox environment (e.g. dx-devenv).
Testing Manual Images
Testing Uploaded Images