Remove Resource Factory #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jriddle-linode
commented
Sep 7, 2022
jriddle-linode
commented
- endpoints are now sprintfs
- all code relevant to an endpoint is in its respective file instead of spread out through code base
LBGarber
reviewed
Sep 16, 2022
| @@ -59,72 +58,6 @@ type Client struct { | |||
| loadedProfile string | |||
|
|
|||
| configProfiles map[string]ConfigProfile | |||
|
|
|||
| Account *Resource | |||
There was a problem hiding this comment.
Just a note that we'll need to add a breaking change note to the release notes
added 6 commits
September 19, 2022 16:32
LBGarber
approved these changes
Oct 5, 2022
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
removed resource factory from client that was used to generate endpoint urls moved URLs to strings and sprints reformatted some code to simplify and make all the files more similar
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
removed resource factory from client that was used to generate endpoint urls moved URLs to strings and sprints reformatted some code to simplify and make all the files more similar
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
removed resource factory from client that was used to generate endpoint urls moved URLs to strings and sprints reformatted some code to simplify and make all the files more similar
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 14, 2023
removed resource factory from client that was used to generate endpoint urls moved URLs to strings and sprints reformatted some code to simplify and make all the files more similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.