Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding /acctest for running fixtures from a PR #246

Merged
merged 18 commits into from
May 10, 2022
Merged

adding /acctest for running fixtures from a PR #246

merged 18 commits into from
May 10, 2022

Conversation

jriddle-linode
Copy link
Collaborator

@jriddle-linode jriddle-linode commented Apr 18, 2022 •
edited
Loading

/acctest sha=023efd8 tests=TestAccount

@jriddle-linode jriddle-linode marked this pull request as ready for review May 4, 2022 14:20
@jriddle-linode jriddle-linode requested a review from LBGarber May 4, 2022 14:36
LBGarber
LBGarber suggested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@LBGarber LBGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small things 🙂

test/integration/account_oauth_client_test.go Outdated Show resolved Hide resolved
test/integration/account_oauth_client_test.go Outdated Show resolved Hide resolved
.github/workflows/integration_tests_pr.yml Outdated Show resolved Hide resolved
test/integration/instance_stats_test.go Show resolved Hide resolved
@jriddle-linode jriddle-linode merged commit 19d119b into linode:main May 10, 2022
@jriddle-linode jriddle-linode deleted the prtests branch May 10, 2022 14:36
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@jriddle-linode
adding /acctest for running fixtures from a PR (linode#246)
22b789d 
example: /acctest sha=023efd8 tests=TestAccount
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@jriddle-linode
adding /acctest for running fixtures from a PR (linode#246)
7dcc304 
example: /acctest sha=023efd8 tests=TestAccount
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
@jriddle-linode
adding /acctest for running fixtures from a PR (linode#246)
5589a2c 
example: /acctest sha=023efd8 tests=TestAccount
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 14, 2023
@jriddle-linode
adding /acctest for running fixtures from a PR (linode#246)
43b3a1a 
example: /acctest sha=023efd8 tests=TestAccount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LBGarber LBGarber LBGarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jriddle-linode @LBGarber