Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate account_info to use common info module #562

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Migrate account_info to use common info module #562

merged 2 commits into from
Aug 16, 2024

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Aug 14, 2024 •
edited
Loading

📝 Description

Migrated account_info module to use the common info module.

✔️ How to Test

Integration Test

make TEST_ARGS="-v account_info" test

Manual Test

  1. In an ansible_linode sandbox environment (e.g. dx-devenv), run the following:
- name: test
  hosts: localhost
  tasks:
    - name: Get info about current account
      linode.cloud.account_info:
      register: account_info
  1. Ensure that the account info is successfully returned.

@ezilber-akamai ezilber-akamai added do-not-merge PRs that should not be merged until the commented issue is resolved improvement for improvements in existing functionality in the changelog. labels Aug 14, 2024
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 14, 2024 18:44
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and zliang-akamai and removed request for a team August 14, 2024 18:44
@ezilber-akamai ezilber-akamai force-pushed the TPT-2920-account-info-list branch from 7c31a90 to a5f8838 Compare August 14, 2024 18:47
@lgarber-akamai lgarber-akamai mentioned this pull request Aug 15, 2024
Merged
@ezilber-akamai ezilber-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Aug 15, 2024
lgarber-akamai
lgarber-akamai approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed after removing the skip and re-adding the environment section, nice work!

yec-akamai
yec-akamai approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ezilber-akamai ezilber-akamai merged commit 3172934 into linode:dev Aug 16, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2920-account-info-list branch August 16, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yec-akamai yec-akamai yec-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@zliang-akamai zliang-akamai Awaiting requested review from zliang-akamai zliang-akamai is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezilber-akamai @lgarber-akamai @yec-akamai