Helm add resource block linkerd-jaeger chart #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
reviewed
Jan 17, 2022
There was a problem hiding this comment.
Thanks @yuriydzobak. I've added a comment about the comments. Also please take care of the DCO for the PR checks to pass.
Signed-off-by: yuriydzobak <yurii.dzobak@lotusflare.com>
Signed-off-by: yuriydzobak <yurii.dzobak@lotusflare.com>
alpeb
reviewed
Jan 17, 2022
There was a problem hiding this comment.
Thanks for the quick changes 👍
CI is still failing because some test golden files still need to be updated. You can do this automatically with go test ./... -update and push the changes. Also it seems you're using helm-docs v1.5, while our CI is using v1.4. You can call the command with bin/helm-docs and CI should stop complaning 😉
Pothulapati
approved these changes
Jan 18, 2022
Signed-off-by: yuriydzobak <yurii.dzobak@lotusflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Problem
jaeger-injector deployment doesn't have resource block.
Solution
Added into values and deployment resources block