build: upgrade to Go 1.17 #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
reviewed
Nov 29, 2021
| @@ -53,6 +51,120 @@ require ( | |||
| sigs.k8s.io/yaml v1.3.0 | |||
| ) | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
I don't see why this require block is required, as we have one above!
There was a problem hiding this comment.
This is automatically added when I run go mod tidy -go=1.17. This enables module graph pruning and lazy module loading supported by Go 1.17 and higher.
This commit introduces three changes: 1. Update the `go` directive in `go.mod` to 1.17 2. Update all Dockerfiles from `golang:1.16.2` to `golang:1.17.3` 3. Update all CI to use Go 1.17 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit synchronizes `//go:build` lines with `// +build` lines. Reference: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
alpeb
approved these changes
Nov 30, 2021
kleimkuhler
added a commit
that referenced
this pull request
Dec 8, 2021
#7371 upgraded the Go version which included using the new formats for [build constraints](https://pkg.go.dev/cmd/go#hdr-Build_constraints). This removes the old ones that are no longer used. Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
olix0r
pushed a commit
that referenced
this pull request
Apr 12, 2022
* build: upgrade to Go 1.17 This commit introduces three changes: 1. Update the `go` directive in `go.mod` to 1.17 2. Update all Dockerfiles from `golang:1.16.2` to `golang:1.17.3` 3. Update all CI to use Go 1.17 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * chore: run `go fmt ./...` This commit synchronizes `//go:build` lines with `// +build` lines. Reference: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> (cherry picked from commit f2fb35a) Signed-off-by: Oliver Gould <ver@buoyant.io>
olix0r
pushed a commit
that referenced
this pull request
Apr 14, 2022
#7371 upgraded the Go version which included using the new formats for [build constraints](https://pkg.go.dev/cmd/go#hdr-Build_constraints). This removes the old ones that are no longer used. Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three changes:
Update the
godirective ingo.modto 1.17. Note: the additionalrequiredirective enables module graph pruning and lazy module loading supported by Go 1.17 and higher. It is added automatically by runninggo mod tidy -go=1.17.Update all Dockerfiles from
golang:1.16.2togolang:1.17.3Update all CI to use Go 1.17