-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the linkerd-controller
pod
#6039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we got rid of the `Version` API (#6000) and the destination API forwarding business in `linkerd-controller` (#5993), we can get rid of the `linkerd-controller` pod. ## Removals - Deleted everything under `/controller/api/public` and `/controller/cmd/public-api`. - Moved `/controller/api/public/test_helper.go` to `/controller/api/destination/test_helper.go` because those are really utils for destination testing. I also extracted from there the prometheus mock structs and put that under `/pkg/prometheus/test_helper.go`, which is now by both the `linkerd diagnostics endpoints` and the `metrics-api` tests, removing some duplication. - Deleted the `controller.yaml` and `controller-rbac.yaml` helm templates along with the `publicAPIResources` and `publicAPIProxyResources` helm values. ## Health checks - Removed the `can initialize the client` check given such client is no longer needed. The `linkerd-api` section was left with only the check `control pods are ready`, so I moved that under the `linkerd-existence` section and got rid of the `linkerd-api` section altogether. - In that same `linkerd-existence` section, got rid of the `controller pod is running` check. ## Other changes - Fixed the Control Plane section of the dashboard, taking account the disappearance of `linkerd-controller` and previously, of `linkerd-sp-validator`.
adleong
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pothulapati
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome Work! :)
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
* Remove the `linkerd-controller` pod Now that we got rid of the `Version` API (linkerd#6000) and the destination API forwarding business in `linkerd-controller` (linkerd#5993), we can get rid of the `linkerd-controller` pod. ## Removals - Deleted everything under `/controller/api/public` and `/controller/cmd/public-api`. - Moved `/controller/api/public/test_helper.go` to `/controller/api/destination/test_helper.go` because those are really utils for destination testing. I also extracted from there the prometheus mock structs and put that under `/pkg/prometheus/test_helper.go`, which is now by both the `linkerd diagnostics endpoints` and the `metrics-api` tests, removing some duplication. - Deleted the `controller.yaml` and `controller-rbac.yaml` helm templates along with the `publicAPIResources` and `publicAPIProxyResources` helm values. ## Health checks - Removed the `can initialize the client` check given such client is no longer needed. The `linkerd-api` section was left with only the check `control pods are ready`, so I moved that under the `linkerd-existence` section and got rid of the `linkerd-api` section altogether. - In that same `linkerd-existence` section, got rid of the `controller pod is running` check. ## Other changes - Fixed the Control Plane section of the dashboard, taking account the disappearance of `linkerd-controller` and previously, of `linkerd-sp-validator`. Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
dadjeibaah
pushed a commit
that referenced
this pull request
Jun 28, 2021
Now that we no longer have a `controller` pod after #6039, there is no need to port-forward the controller pod in the bin/web script. This change removes the code that does that. Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
kleimkuhler
pushed a commit
that referenced
this pull request
Jun 29, 2021
Now that we no longer have a `controller` pod after #6039, there is no need to port-forward the controller pod in the bin/web script. This change removes the code that does that. Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
sannimichaelse
pushed a commit
to sannimichaelse/linkerd2
that referenced
this pull request
Aug 1, 2021
Now that we no longer have a `controller` pod after linkerd#6039, there is no need to port-forward the controller pod in the bin/web script. This change removes the code that does that. Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
sannimichaelse
pushed a commit
to sannimichaelse/linkerd2
that referenced
this pull request
Aug 13, 2021
Now that we no longer have a `controller` pod after linkerd#6039, there is no need to port-forward the controller pod in the bin/web script. This change removes the code that does that. Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io> Signed-off-by: Sanni Michael <sannimichaelse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we got rid of the
Version
API (#6000) and the destination API forwarding business inlinkerd-controller
(#5993), we can get rid of thelinkerd-controller
pod.Removals
/controller/api/public
and/controller/cmd/public-api
./controller/api/public/test_helper.go
to/controller/api/destination/test_helper.go
because those are really utils for destination testing. I also extracted from there the prometheus mock structs and put that under/pkg/prometheus/test_helper.go
, which is now by both thelinkerd diagnostics endpoints
and themetrics-api
tests, removing some duplication.controller.yaml
andcontroller-rbac.yaml
helm templates along with thepublicAPIResources
andpublicAPIProxyResources
helm values.Health checks
can initialize the client
check given such client is no longer needed. Thelinkerd-api
section was left with only the checkcontrol pods are ready
, so I moved that under thelinkerd-existence
section and got rid of thelinkerd-api
section altogether.linkerd-existence
section, got rid of thecontroller pod is running
check.Other changes
linkerd-controller
and previously, oflinkerd-sp-validator
.