Move CP check after the readiness check #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the `can initialize client` and `can query the control plane API` checks from the `linkerd-existence` section to the `linkerd-api` because they required the `linkerd-controller` pod to not just be "Running" but actually be ready. This was causing `linkerd check` to show some port-forwarding warnings when ran right after install. This also allowed getting rid of the `CheckPublicAPIClientOrExit` function and directly use `CheckPublicAPIClientOrRetryOrExit` (better naming punted for later) which was refactored so it always runs the `linkerd-api` checks before retrieving the client.
adleong
approved these changes
Mar 1, 2021
olix0r
approved these changes
Mar 1, 2021
|
Several additional fixes were required to have CI pass:
|
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
* Move CP check after the readiness check Moved the `can initialize client` and `can query the control plane API` checks from the `linkerd-existence` section to the `linkerd-api` because they required the `linkerd-controller` pod to not just be "Running" but actually be ready. This was causing `linkerd check` to show some port-forwarding warnings when ran right after install. This also allowed getting rid of the `CheckPublicAPIClientOrExit` function and directly use `CheckPublicAPIClientOrRetryOrExit` (better naming punted for later) which was refactored so it always runs the `linkerd-api` checks before retrieving the client. Other changes: - Temporarily disabled `upgrade-edge` test because the latest edge has this readiness check issue - Have the upgrade tests do proper pruning (stolen for @Pothulapati's linkerd#5673 😉 ) - Added missing label to tap SA (fixes linkerd#5850) - Complete tap-injector Service selector Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
* Move CP check after the readiness check Moved the `can initialize client` and `can query the control plane API` checks from the `linkerd-existence` section to the `linkerd-api` because they required the `linkerd-controller` pod to not just be "Running" but actually be ready. This was causing `linkerd check` to show some port-forwarding warnings when ran right after install. This also allowed getting rid of the `CheckPublicAPIClientOrExit` function and directly use `CheckPublicAPIClientOrRetryOrExit` (better naming punted for later) which was refactored so it always runs the `linkerd-api` checks before retrieving the client. Other changes: - Temporarily disabled `upgrade-edge` test because the latest edge has this readiness check issue - Have the upgrade tests do proper pruning (stolen for @Pothulapati's linkerd#5673 😉 ) - Added missing label to tap SA (fixes linkerd#5850) - Complete tap-injector Service selector Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
can initialize clientandcan query the control plane APIchecks from the
linkerd-existencesection to thelinkerd-apibecausethey required the
linkerd-controllerpod to not just be "Running" butactually be ready.
This was causing
linkerd checkto show some port-forwarding warningswhen ran right after install.
This also allowed getting rid of the
CheckPublicAPIClientOrExitfunctionand directly use
CheckPublicAPIClientOrRetryOrExit(better namingpunted for later) which was refactored so it always runs the
linkerd-apichecks before retrieving the client.