service profile generation work offline using --ignore-cluster #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
adleong
reviewed
Jan 6, 2021
|
@adleong Cool, I am working on this :) |
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
kleimkuhler
reviewed
Jan 7, 2021
There was a problem hiding this comment.
I have two smaller comments but rest is looking good. Thanks @piyushsingariya!
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
kleimkuhler
approved these changes
Jan 7, 2021
|
Thanks, @adleong @kleimkuhler 😄 |
|
Awesome work @piyushsingariya! |
|
Thanks! @purkhusid 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Related to issue #5401
Problem
Introduce offline profile generation to skip the access check to k8s cluster
Solution
the profile command be updated to support the --ignore-cluster flag to skip the check and generate a profile offline
Introduced a new boolean variable
ignoreClusterto trigger offline profile generationFixes #[GitHub issue ID]
#5401