Use a globing operator in top-line metrics dashboard for the "all" value #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Miller <mamiller@rosettastone.com>
alpeb
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Thanks @mmiller1, this works great! 👍
Before:
sum(irate(response_total{classification="success", deployment=~"emoji|linkerd-controller|linkerd-destination|linkerd-grafana|linkerd-identity|linkerd-prometheus|linkerd-proxy-injector|linkerd-sp-validator|linkerd-tap|linkerd-web|vote-bot|voting|web"}[30s])) / sum(irate(response_total{deployment=~"emoji|linkerd-controller|linkerd-destination|linkerd-grafana|linkerd-identity|linkerd-prometheus|linkerd-proxy-injector|linkerd-sp-validator|linkerd-tap|linkerd-web|vote-bot|voting|web"}[30s]))
After:
sum(irate(response_total{classification="success", deployment=~".*"}[30s])) / sum(irate(response_total{deployment=~".*"}[30s]))
|
Cool! Does this change correspond to what is documented here under Custom all value? Just want to better understand the context around this change. There are a number of other places that still use |
Signed-off-by: Matt Miller <mamiller@rosettastone.com>
|
Yes, @ihcsim that is the documentation section that discusses what this changes, I don't see any reason why no to make the change to the other variables, so I added a commit to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a globing operator in top-line metrics dashboard for the "all" value
In clusters with many namespaces and deployments, the grafana query to prometheus for "all" may be too large for prometheus to return results.
Instead of having grafana query prometheus for every namespace/deployment literally, we can use a globing operator to shorten the request length so results can be returned in clusters where there are large numbers of deployments and namespaces.