Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More succinct HTTPError messages #3221

Merged
merged 1 commit into from
Aug 9, 2019
Merged

More succinct HTTPError messages #3221

merged 1 commit into from
Aug 9, 2019

Conversation

siggy
Copy link
Member

@siggy siggy commented Aug 8, 2019

Before:
HTTP error, status Code [503], wrapped error is: unexpected response

After:
HTTP error, status Code [503] (unexpected response)

Signed-off-by: Andrew Seigner siggy@buoyant.io

@siggy siggy self-assigned this Aug 8, 2019
@siggy siggy requested a review from kleimkuhler August 8, 2019 23:47
@siggy siggy changed the title More succint HTTPError messages More succinct HTTPError messages Aug 8, 2019
Before:
`HTTP error, status Code [503], wrapped error is: unexpected response`

After:
`HTTP error, status Code [503] (unexpected response)`

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy force-pushed the siggy/no-wrapping branch from 5187731 to b09ec86 Compare August 8, 2019 23:49
Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 9, 2019

Integration test results for b09ec86: success 🎉
Log output: https://gist.github.com/afdb84f0d2595ba93f3564c0c6bb566f

@siggy siggy merged commit 0487688 into master Aug 9, 2019
@siggy siggy deleted the siggy/no-wrapping branch August 9, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants