-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes for edge-19.8.1
#3184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
kleimkuhler
requested review from
admc,
klingerf,
olix0r and
wmorgan
as code owners
August 1, 2019 21:58
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
admc
approved these changes
Aug 1, 2019
Integration test results for 4089127: success 🎉 |
siggy
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left a few comments 👍 🚢
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Integration test results for 6378fd7: success 🎉 |
cpretzer
pushed a commit
that referenced
this pull request
Aug 6, 2019
**Significant Update** This edge release introduces a new tap APIService. The Kubernetes apiserver authenticates the requesting tap user and then forwards tap requests to the new tap APIServer. The `linkerd tap` command now makes requests against the APIService. With this release, users must be authorized via RBAC to use the `linkerd tap` command. Specifically `linkerd tap` requires the `watch` verb on all resources in the `tap.linkerd.io/v1alpha1` APIGroup. More granular access is also available via sub-resources such as `deployments/tap` and `pods/tap`. * CLI * Added a check to the `linkerd check` command to validate the user has privileges necessary to create CronJobs * Introduced the `linkerd --as` flag which allows users to impersonate another user for Kubernetes operations * The `linkerd tap` command now makes requests against the tap APIService * Controller * Added HTTP security headers on all dashboard responses * Fixed nil pointer dereference in the destination service when an endpoint does not have a `TargetRef` * Added resource limits when HA is enabled * Added RSA support to TLS libraries * Updated the destination service to return `InvalidArgument` for external name services so that the proxy does not immediately fail the request * The `l5d-require-id` header is now set on tap requests so that a connection is established over TLS * Introduced the `APIService/v1alpha1.tap.linkerd.io` global resource * Introduced the `ClusterRoleBinding/linkerd-linkerd-tap-auth-delegator` global resource * Introduced the `Secret/linkerd-tap-tls` resource into the `linkerd` namespace * Introduced the `RoleBinding/linkerd-linkerd-tap-auth-reader` resource into the `kube-system` namespace * Proxy * Added the `LINKERD2_PROXY_TAP_SVC_NAME` environment variable so that the tap server attempts to authorize client identities * Internal * Replaced `dep` with Go modules for dependency management Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant Update
This edge release introduces a new tap APIService. The Kubernetes apiserver
authenticates the requesting tap user and then forwards tap requests to the new
tap APIServer. The
linkerd tap
command now makes requests against theAPIService.
With this release, users must be authorized via RBAC to use the
linkerd tap
command. Specifically
linkerd tap
requires thewatch
verb on all resourcesin the
tap.linkerd.io/v1alpha1
APIGroup. More granular access is alsoavailable via sub-resources such as
deployments/tap
andpods/tap
.linkerd check
command to validate the user hasprivileges necessary to create CronJobs
linkerd --as
flag which allows users to impersonate anotheruser for Kubernetes operations
linkerd tap
command now makes requests against the tap APIServicedoes not have a
TargetRef
InvalidArgument
for externalname services so that the proxy does not immediately fail the request
l5d-require-id
header is now set on tap requests so that a connectionis established over TLS
APIService/v1alpha1.tap.linkerd.io
global resourceClusterRoleBinding/linkerd-linkerd-tap-auth-delegator
global resource
Secret/linkerd-tap-tls
resource into thelinkerd
namespace
RoleBinding/linkerd-linkerd-tap-auth-reader
resource intothe
kube-system
namespaceLINKERD2_PROXY_TAP_SVC_NAME
environment variable so that the tapserver attempts to authorize client identities
dep
with Go modules for dependency managementSigned-off by: Kevin Leimkuhler kleimkuhler@icloud.com