Show pod status more clearly (#1967) #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanbeber
force-pushed
the
pod-status
branch
3 times, most recently
from
de17e65 to
a2351b2
Compare
|
Thank you! We'll get you a review shortly =) |
adleong
reviewed
Jul 5, 2019
During operations with `linkerd stat` sometimes it's not clear the actual pod status. This commit introduces a method, to the `k8s`package, getting the pod status, based on [`kubectl` logic](https://github.com/kubernetes/kubernetes/blob/33a3e325f754d179b25558dee116fca1c67d353a/pkg/printers/internalversion/printers.go#L558-L640) to expose the `STATUS` column for pods . Also, it changes the stat command on the` cli` package adding a column when the resource type is a Pod. Fixes linkerd#1967 Signed-off-by: Jonathan Juares Beber <jonathanbeber@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During operations with
linkerd statsometimes it's not clear the actualpod status.
This commit introduces a method, to the
k8spackage, getting the pod status,based on
kubectllogicto expose the
STATUScolumn for pods . Also, it changes the stat commandon the
clipackage adding a column when the resource type is a Pod.Fixes #1967