Added Jobs Resource to Linkerd Dashboard along with grafana. #2439
Conversation
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
There was a problem hiding this comment.
Looking good @Pothulapati ! Needs one fix in the Go code...
There was a problem hiding this comment.
Looks good. Just one comment and one nit:
The Job parent type isn't showing up in the filter drop-down in the Tap and Top pages.
You can fix it with:
diff --git a/web/app/js/components/util/TapUtils.jsx b/web/app/js/components/util/TapUtils.jsx
index 3b95cdec..5a602979 100644
--- a/web/app/js/components/util/TapUtils.jsx
+++ b/web/app/js/components/util/TapUtils.jsx
@@ -36,7 +36,8 @@ export const tapResourceTypes = [
"daemonset",
"pod",
"replicationcontroller",
- "statefulset"
+ "statefulset",
+ "job"
];
// use a generator to get this object, to prevent it from being overwrittenAs for the nit, would you mind converting grafana/dashboards/job.json to 2-space indentation, to be consistent with all the other dashboard json? Thanks.
|
This looks great! The screenshots are super useful =) |
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
|
LGTM 👍 @siggy Final thoughts? |
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
There was a problem hiding this comment.
Had a couple comments, apologies for not catching them the first time around.
There's a subtle bug in web/app/js/components/util/Utils.js where isResource relies on shortNameLookup to determine whether a string is a resource. This means you'll need to add "job": "job", to shortNameLookup, even though it doesn't actually need a short name.
To validate the fix, observe that the breadcrumb at the top correctly renders as Jobs rather than jobs:
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
#2416 Added Support for jobs resource in the cli parts of linkerd i.e stat, top, routes, etc. This PR adds support for jobs resource in the dashboard along with grafana dashboard for Jobs Resources.
This PR used the emojivoto-job yaml i.e BuoyantIO/emojivoto#63 to create the job resources.
Linkerd Dashboard Home Page
Jobs Page
TAP
Top Routes
Grafana Jobs Dashboard
cc @siggy @grampelberg