fix(policy): ensure status controller honors leader expiry #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/policy-log-noise
branch
from
712c9bd to
9bd5387
Compare
cratelyn
approved these changes
Nov 25, 2024
olix0r
force-pushed
the
ver/policy-log-leader
branch
from
a6c7071 to
267214f
Compare
The status controller updates its leadership state every time the lease changes. But if the lease expires and does not update for some reason, the contoller incorrectly continues to act as the leader. This change ensures that the controller checks the lease on each iteration to ensure that it correctly honors the lease contract.
olix0r
force-pushed
the
ver/policy-log-leader
branch
from
267214f to
73d753a
Compare
adleong
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status controller updates its leadership state every time the lease changes. But if the lease expires and does not update for some reason, the contoller incorrectly continues to act as the leader.
This change ensures that the controller checks the lease on each iteration to ensure that it correctly honors the lease contract.