Add json output to install and related commands #12641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
alpeb
reviewed
May 30, 2024
cli/cmd/install.go
Outdated
Comment on lines
440
to
443
| } else if format == "yaml" { | ||
| _, err = w.Write(buf.Bytes()) | ||
| return err | ||
| } |
There was a problem hiding this comment.
Same nit:
Suggested change
| } else if format == "yaml" { | |
| _, err = w.Write(buf.Bytes()) | |
| return err | |
| } | |
| if format == "yaml" { | |
| _, err = w.Write(buf.Bytes()) | |
| return err | |
| } |
mateiidavid
reviewed
May 31, 2024
Signed-off-by: Alex Leong <alex@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add support for the
--output/-oflag in linkerd install and related commands. The supported output formats are yaml (default) and json. Kubectl is able to accept both of these formats which means that the output can be piped into kubectl regardless of which output format is used.The full list of install related commands which we add json support to is: