Helm Chart - allow setting revisionHistoryLimit #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going to make this change for the control-plane chart, it would be good to make this uniform across all others as well. |
|
@olix0r , sure. Part of same PR? |
|
@DrFaust92 Yes, please :) |
|
olix0r done for all relevant refs i found |
|
forgot to generate helm-docs, added @olix0r. sorry about that |
alpeb
reviewed
Mar 28, 2024
|
alpeb I think i made all relevant changes, lmk if anything else is needed |
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
alpeb
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks @DrFaust92 . I've rebased it and fixed some conflicts to move this forward.
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Mark S <the@wondersmith.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting revisionHistoryLimit to remove old accumulated values. default value is 10 so the added param should be no op