convert ServerAuthorizations to AuthorizationPolicies #10079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
kleimkuhler
approved these changes
Jan 6, 2023
alpeb
approved these changes
Jan 10, 2023
Comment on lines
53
to
54
| # Ideally, this should be restricted to the actual set of IPs the kubelet API | ||
| # server uses for webhooks in a cluster. This can't easily be discovered. |
There was a problem hiding this comment.
IIUC, this actually targets the kube-api, not the kubelet.
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
This was referenced Mar 30, 2023
adleong
added a commit
that referenced
this pull request
Apr 5, 2023
Fixes #10612 The Linkerd multicluster gateway chart contains an AuthorizationPolicy for allowing probes to the gateway from remote linked clusters. However, now that probes are automatically authorized, this explicit AuthorizationPolicy is no longer necessary. Many such probe authorization resources were removed in #10079 but this one remained and, in fact, became a duplicate of the regular gateway AuthorizationPolicy. Since probe authorizations are no longer explicitly necessary, this duplicate policy can be removed. Signed-off-by: Alex Leong <alex@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linkerd extension charts use ServerAuthorization resources. AuthorizationPolicies are now the recommended resource to use in favor of ServerAuthorizations. We replace all of the ServerAuthorization resources in the Linkerd extension charts with AuthorizationPolicy resources.
Signed-off-by: Alex Leong alex@buoyant.io