You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We plan on implementing proxy injection tests for conformance validation which are similar to the existing integration tests for inject. Currently, the inject integration tests consist of a some reusable helper functions which the conformance validation project could benefit from using. However, these helpers are private to test/inject_test.go, and cannot be used outside of the linkerd2 repo.
How can this be solved?
These helper functions could be moved to the testutil package and made public. This way, both, the integration tests as well as the conformance tests could utilise common functionality without having to rewrite code. In particular, the following methods require this refactor:
Problem
We plan on implementing proxy injection tests for conformance validation which are similar to the existing integration tests for
inject
. Currently, theinject
integration tests consist of a some reusable helper functions which the conformance validation project could benefit from using. However, these helpers are private totest/inject_test.go
, and cannot be used outside of the linkerd2 repo.How can this be solved?
These helper functions could be moved to the
testutil
package and made public. This way, both, the integration tests as well as the conformance tests could utilise common functionality without having to rewrite code. In particular, the following methods require this refactor:Cc: @alpeb @Pothulapati
The text was updated successfully, but these errors were encountered: