Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance validation: refactor existing helpers from inject integration tests #4643

Closed
mayankshah1607 opened this issue Jun 21, 2020 · 0 comments · Fixed by #4644
Closed

Comments

@mayankshah1607
Copy link
Contributor

mayankshah1607 commented Jun 21, 2020

Problem

We plan on implementing proxy injection tests for conformance validation which are similar to the existing integration tests for inject. Currently, the inject integration tests consist of a some reusable helper functions which the conformance validation project could benefit from using. However, these helpers are private to test/inject_test.go, and cannot be used outside of the linkerd2 repo.

How can this be solved?

These helper functions could be moved to the testutil package and made public. This way, both, the integration tests as well as the conformance tests could utilise common functionality without having to rewrite code. In particular, the following methods require this refactor:

Cc: @alpeb @Pothulapati

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant