Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JMH version, fix sub-project test dependency #276

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

evanw555
Copy link
Contributor

This addresses a strange and hard-to-reproduce bug whereby the d2-benchmark sub-project fails to build. This seems to be the fix with the most consistent results.

This addresses a strange and hard-to-reproduce bug whereby the
d2-benchmark sub-project fails to build. This seems to be the fix with
the most consistent results.
@evanw555 evanw555 requested a review from davidhoa April 29, 2020 23:01
Copy link

@davidhoa davidhoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I don't believe I have ACLs.

@evanw555 evanw555 merged commit 3794193 into master Apr 30, 2020
@evanw555 evanw555 deleted the fix/d2-jmh-failures branch April 30, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants