Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc links and fix exports #594

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix doc links and fix exports #594

merged 3 commits into from
Aug 5, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 5, 2022

closes #593

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

fix docs links and fixes all missing exports

@sgratzl sgratzl requested a review from thinkh August 5, 2022 01:01
@sgratzl sgratzl self-assigned this Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit 38eccc8
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/62ec6bd3cc780600083c8107
😎 Deploy Preview https://deploy-preview-594--lineupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a general question about the change in the package.json.

Comment on lines +171 to +175
"dependenciesMeta": {
"lineupengine@2.5.0": {
"unplugged": true
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgratzl sgratzl merged commit 9bf981d into develop Aug 5, 2022
@sgratzl sgratzl deleted the sgratzl/docs branch August 5, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants