Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for custom instance id #580

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Add option for custom instance id #580

merged 6 commits into from
Jul 11, 2022

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jul 11, 2022

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

  • By default LineUp is generating a random id with 3 characters (e.g. luc75)
  • This PR allows to set a deterministic id for this LineUp instance in the options (i.e., options.instanceId)
  • If no instanceId is set or by default the id is generated as before

@thinkh thinkh requested a review from sgratzl July 11, 2022 12:56
@netlify
Copy link

netlify bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit 81b157a
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/62cc8eb12ef9b00008676d21
😎 Deploy Preview https://deploy-preview-580--lineupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thinkh thinkh added type: feature New feature or request lineup: v4 All issues related to LineUp v4 labels Jul 11, 2022
sgratzl
sgratzl approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thinkh thinkh merged commit c2cd304 into develop Jul 11, 2022
@thinkh thinkh deleted the thinkh/add-instance-id-option branch July 11, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratzl sgratzl sgratzl approved these changes

Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @sgratzl