Correctly log elapsed milliseconds in CentralDogmaBeanFactory
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarboniteKream
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
jrhee17
approved these changes
Jul 23, 2024
ikhoon
approved these changes
Jul 23, 2024
| @@ -328,7 +328,7 @@ public <T> T get(T defaultValue, Class<T> beanType, Consumer<T> changeListener, | |||
| throw ex; | |||
| } | |||
| } | |||
| final long elapsedMillis = System.nanoTime() - t0; | |||
| final long elapsedMillis = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - t0); | |||
|
@KarboniteKream 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the elapsed time in
CentralDogmaBeanFactory#get()is logged, it prints nanoseconds withmsunit.Modifications:
Result:
The logs correctly display the elapsed time of obtaining the initial value.