Make CI run all branches on push #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create branches for patch versions that need to be verified by CI.
|
I verified that CI ran on non-main branches. https://github.com/ikhoon/armeria/actions/runs/10107663381 |
jrhee17
approved these changes
Jul 26, 2024
Comment on lines
4
to
+5
| branches: | ||
| - main | ||
| - "**" |
There was a problem hiding this comment.
Question) Is this equivalent to if we just remove these two lines altogether?
There was a problem hiding this comment.
I tried this setting on my forked repo first but it didn't seem to work.
on:
push:
tags-ignore:
# The release versions will be verified by 'publish-release.yml'
- armeria-*
pull_request:
merge_group:
minwoox
added a commit
to minwoox/centraldogma
that referenced
this pull request
Jul 26, 2024
|
Thanks for the quick review. |
|
Added the same change to Central dogma: |
ikhoon
added a commit
that referenced
this pull request
Jul 26, 2024
We create branches for patch versions that need to be verified by CI. Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet > '**' : Matches all branch and tag names. This is the default behavior when you don't use a branches or tags filter.
|
CI for 1.29.3 is now running. https://github.com/line/armeria/actions/runs/10107942116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create branches for patch versions that need to be verified by CI.
Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet