Ensure annotated service with Kotlin suspend function supports nullable parameters #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le parameters. Motivation: A regression was identified where an annotated service with a Kotlin suspend function does not work as expected when the parameter is nullable. Modifications: - Updated the function call to include null parameters when invoking `kFunction.callSuspendBy()`. Result: - The annotated service with a Kotlin suspend function works correctly even with a nullable parameter.
ikhoon
approved these changes
Apr 26, 2024
| methods.size == 1, | ||
| "Unable to find a single box-impl synthetic static method in %s", | ||
| classifier.java.name, | ||
| if (!parameter.isOptional || args[index] != null) { |
minwoox
added a commit
that referenced
this pull request
Apr 26, 2024
…le parameters (#5638) Motivation: A regression was identified where an annotated service with a Kotlin suspend function does not work as expected when the parameter is nullable. Modifications: - Updated the function call to include null parameters when invoking `kFunction.callSuspendBy()`. Result: - The annotated service with a Kotlin suspend function works correctly even with a nullable parameter.
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this pull request
Jun 8, 2024
…le parameters (line#5638) Motivation: A regression was identified where an annotated service with a Kotlin suspend function does not work as expected when the parameter is nullable. Modifications: - Updated the function call to include null parameters when invoking `kFunction.callSuspendBy()`. Result: - The annotated service with a Kotlin suspend function works correctly even with a nullable parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A regression was identified where an annotated service with a Kotlin suspend function does not work as expected when the parameter is nullable.
Modifications:
kFunction.callSuspendBy().Result: