Add CoroutineHttpService for handle request within Coroutine suspend #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
minwoox
reviewed
Apr 15, 2024
| * invoke the suspendedServe method within the CoroutineScope | ||
| */ | ||
| override fun serve(ctx: ServiceRequestContext, req: HttpRequest): HttpResponse { | ||
| return HttpResponse.of(CoroutineScope(ctx.asCoroutineContext()).future { // Do we also need to add user context? |
There was a problem hiding this comment.
Let's also support the userContext that maybe set by a CoroutineContextService:
You may want to refer to this code snippet to see how it's implemented:
kotlin/src/main/kotlin/com/linecorp/armeria/server/kotlin/CoroutineHttpService.kt
Outdated
Show resolved
Hide resolved
| "/hello", | ||
| object : CoroutineHttpService { | ||
| override suspend fun suspendedServe(ctx: ServiceRequestContext, req: HttpRequest): HttpResponse { | ||
| return HttpResponse.of("hello world") |
There was a problem hiding this comment.
Let's check if the context is propagated correctly.
You might want to refer to this implementation:
Does the extension method here refer to the extension function of the |
|
Right. Should we add Server
.builder()
.coroutineService("/prefix", myCoroutineService)
... |
|
Let's add the extension methods in the next PR. 😉 |
|
Great job, @pinest94! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HttpServicefrom a Kotlin coroutine #5442Modifications:
Result:
HttpServicefrom a Kotlin coroutine #5442.CoroutineHttpServicethat runs your service in a coroutine scope.