Try using testNg using junit engine #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5404 +/- ##
============================================
+ Coverage 73.81% 73.93% +0.11%
- Complexity 20471 20689 +218
============================================
Files 1777 1791 +14
Lines 75532 76335 +803
Branches 9629 9716 +87
============================================
+ Hits 55756 56435 +679
- Misses 15161 15283 +122
- Partials 4615 4617 +2 ☔ View full report in Codecov by Sentry. |
jrhee17
commented
Jan 25, 2024
| @@ -40,6 +40,7 @@ | |||
| import reactor.core.publisher.Flux; | |||
|
|
|||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
This test hasn't been running until this PR, and it is failing. I've simply added an ignore tag for now.
ikhoon
reviewed
Jan 26, 2024
Co-authored-by: Ikhun Um <ih.pert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
junit-team/testng-engine#87 has been resolved which means that we don't need special handling for testNg
Modifications:
testng-enginegloballyResult: