Fix pts with testng #5339
Merged
Fix pts with testng #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5339 +/- ##
============================================
- Coverage 73.95% 73.66% -0.29%
+ Complexity 20150 20102 -48
============================================
Files 1741 1741
Lines 74353 74353
Branches 9481 9481
============================================
- Hits 54988 54775 -213
- Misses 14876 15041 +165
- Partials 4489 4537 +48 ☔ View full report in Codecov by Sentry. |
ikhoon
reviewed
Dec 20, 2023
build.gradle
Outdated
| @@ -127,7 +129,7 @@ allprojects { | |||
| } | |||
|
|
|||
| predictiveSelection { | |||
| enabled.set(!isCi) | |||
| enabled.set(true) | |||
There was a problem hiding this comment.
Q: Is this an intentional change?
There was a problem hiding this comment.
The commit was added to verify that the build passes with pts enabled. I've reverted this commit 🙇
| @@ -225,6 +224,9 @@ if (rootProject.findProperty('flakyTests') != 'true') { | |||
| } | |||
| } | |||
| } | |||
| dependencies { | |||
| runtimeOnly libs.junit.testng.engine | |||
This reverts commit 07e4e31.
trustin
approved these changes
Dec 27, 2023
eottabom
pushed a commit
to eottabom/armeria
that referenced
this pull request
Jan 18, 2024
Motivation: Recently we have enabled PTS which causes an error when trying to run testNg tests. ``` Execution failed for task ':core:testNg'. > Predictive Test Selection only supports JUnit Platform. ``` It has been pointed out that `TestNg` is supported through `junit-platform`. ref: https://docs.gradle.com/enterprise/predictive-test-selection/#_frameworks_and_languages I see no reason we shouldn't just use `junit-platform` overall as our default test framework launcher. ref: https://gradle.slack.com/archives/C05975D6V7H/p1701969512592219 Note that we are unable to add the testNg globally by default due to the following issue: junit-team/testng-engine#87 Modifications: - Added a test engine `testng` to testing runtime - Modified to always use `useJUnitPlatform()` Result: - We can run testNg tests with PTS enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently we have enabled PTS which causes an error when trying to run testNg tests.
It has been pointed out that
TestNgis supported throughjunit-platform.ref: https://docs.gradle.com/enterprise/predictive-test-selection/#_frameworks_and_languages
I see no reason we shouldn't just use
junit-platformoverall as our default test framework launcher.ref: https://gradle.slack.com/archives/C05975D6V7H/p1701969512592219
Note that we are unable to add the testNg globally by default due to the following issue: junit-team/testng-engine#87
Modifications:
testngto testing runtimeuseJUnitPlatform()Result: